stubgen: Fix valid type detection to allow pipe unions

chadrik · chadrik · commit b9745ef4104d · 2025-02-23T20:55:58.000-08:00
diff --git a/mypy/stubdoc.py b/mypy/stubdoc.py
@@ -21,7 +21,7 @@
 Sig: _TypeAlias = tuple[str, str]
 
 
-_TYPE_RE: Final = re.compile(r"^[a-zA-Z_][\w\[\], .\"\']*(\.[a-zA-Z_][\w\[\], ]*)*$")
+_TYPE_RE: Final = re.compile(r"^[a-zA-Z_][\w\[\], .\"\'|]*(\.[a-zA-Z_][\w\[\], ]*)*$")
 _ARG_NAME_RE: Final = re.compile(r"\**[A-Za-z_][A-Za-z0-9_]*$")
 
 
diff --git a/mypy/test/teststubgen.py b/mypy/test/teststubgen.py
@@ -1405,6 +1405,8 @@ def test_is_valid_type(self) -> None:
         assert is_valid_type("Literal[True]")
         assert is_valid_type("Literal[Color.RED]")
         assert is_valid_type("Literal[None]")
+        assert is_valid_type("str | int")
+        assert is_valid_type("dict[str, int] | int")
         assert is_valid_type(
             'Literal[26, 0x1A, "hello world", b"hello world", u"hello world", True, Color.RED, None]'
         )

Original file line number	Diff line number	Diff line change
`@@ -1405,6 +1405,8 @@ def test_is_valid_type(self) -> None:`
`1405`	`1405`	`assert is_valid_type("Literal[True]")`
`1406`	`1406`	`assert is_valid_type("Literal[Color.RED]")`
`1407`	`1407`	`assert is_valid_type("Literal[None]")`
	`1408`	`+ assert is_valid_type("str \| int")`
	`1409`	`+ assert is_valid_type("dict[str, int] \| int")`
`1408`	`1410`	`assert is_valid_type(`
`1409`	`1411`	`'Literal[26, 0x1A, "hello world", b"hello world", u"hello world", True, Color.RED, None]'`
`1410`	`1412`	`)`