Skip to content

Commit f220ce5

Browse files
authored
teststubtest: drop StubtestIntegration (#9635)
I did some work to speed up stubtest tests substantially in #9621 This is a lesser win. The argument to get rid of it is that it's the slowest mypy test and just testing for crashes on typeshed doesn't provide much value. Since this was written we started running stubtest in typeshed CI and in practice all changes are tested on typeshed anyway. Co-authored-by: hauntsaninja <>
1 parent af99ebc commit f220ce5

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

mypy/test/teststubtest.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -848,9 +848,3 @@ def test_config_file(self) -> None:
848848
)
849849
output = run_stubtest(stub=stub, runtime=runtime, options=[], config_file=config_file)
850850
assert output == ""
851-
852-
853-
class StubtestIntegration(unittest.TestCase):
854-
def test_typeshed(self) -> None:
855-
# check we don't crash while checking typeshed
856-
test_stubs(parse_options(["--check-typeshed"]))

runtests.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
MYPYC_EXTERNAL = 'TestExternal'
2929
MYPYC_COMMAND_LINE = 'TestCommandLine'
3030
ERROR_STREAM = 'ErrorStreamSuite'
31-
STUBTEST_INTEGRATION = 'StubtestIntegration'
3231

3332

3433
ALL_NON_FAST = [
@@ -45,16 +44,12 @@
4544
MYPYC_EXTERNAL,
4645
MYPYC_COMMAND_LINE,
4746
ERROR_STREAM,
48-
STUBTEST_INTEGRATION,
4947
]
5048

5149

5250
# These must be enabled by explicitly including 'mypyc-extra' on the command line.
5351
MYPYC_OPT_IN = [MYPYC_RUN, MYPYC_RUN_MULTI]
5452

55-
# These must be enabled by explicitly including 'stubtest' on the command line.
56-
STUBTEST_OPT_IN = [STUBTEST_INTEGRATION]
57-
5853
# We split the pytest run into three parts to improve test
5954
# parallelization. Each run should have tests that each take a roughly similar
6055
# time to run.
@@ -82,7 +77,6 @@
8277
# Mypyc tests that aren't run by default, since they are slow and rarely
8378
# fail for commits that don't touch mypyc
8479
'mypyc-extra': 'pytest -k "%s"' % ' or '.join(MYPYC_OPT_IN),
85-
'stubtest': 'pytest -k "%s"' % ' or '.join(STUBTEST_OPT_IN),
8680
}
8781

8882
# Stop run immediately if these commands fail

0 commit comments

Comments
 (0)