Skip to content

Use Furo theme for documentation #12348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 24, 2022
Merged

Conversation

97littleleaf11
Copy link
Collaborator

@97littleleaf11 97littleleaf11 commented Mar 14, 2022

Current readthedoc theme cannot fully utilize the width of browser especially when you are using a wide screen. I am choosing Furo since it's quite popular in python community (pip, black, etc).

Other changes:

  • Use mypy instead of Mypy
  • Move introduction to index page, which makes better impression for newcome users.

Closes #12374

@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@97littleleaf11 97littleleaf11 requested a review from JukkaL March 14, 2022 09:15
@TH3CHARLie
Copy link
Collaborator

Some screenshots?

@97littleleaf11
Copy link
Collaborator Author

截屏2022-03-14 下午7 23 39

@jhance
Copy link
Collaborator

jhance commented Mar 17, 2022

I think it looks nice.

@97littleleaf11
Copy link
Collaborator Author

ping @JukkaL

@97littleleaf11
Copy link
Collaborator Author

97littleleaf11 commented Mar 18, 2022

Current readthedoc theme cannot fully utilize the width of browser

hmm, actually it's configurable. Anyway I still vote for furo.

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new theme. Thanks!

@JukkaL JukkaL merged commit fec5320 into python:master Mar 24, 2022
@97littleleaf11 97littleleaf11 deleted the try-furo branch March 24, 2022 14:52
97littleleaf11 pushed a commit that referenced this pull request May 1, 2022
`introduction.rst` has moved into `index.rst` in #12348.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(📚) docs state that they are copyright to some ancient year I've never heard of (2016😳😳😳)
4 participants