Remove slots already defined in base class #13028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
emmatyping
approved these changes
Jun 28, 2022
|
Thanks! |
Gobot1234
pushed a commit
to Gobot1234/mypy
that referenced
this pull request
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove redefining base class slots.
nodes.TypeAlias.lineslot is defined innodes.Contextnodes.TypeAlias.columnslot is defined innodes.Contextnodes.PlaceholderNode.lineslot is defined innodes.Contexttypes.TypeAliasType.lineslot is defined innodes.Contexttypes.TypeAliasType.columnslot is defined innodes.Contexttypes.Overloaded.fallbackslot is defined intypes.FunctionLikeTest Plan
No additional tests required.