Fix type analysis for typing.Unpack #15228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
|
||
| [case testTypeVarTuple] | ||
| # flags: --enable-incomplete-feature=TypeVarTuple --enable-incomplete-feature=Unpack --python-version=3.11 | ||
| from typing import Any, Callable, Unpack, TypeVarTuple |
There was a problem hiding this comment.
CI fails if this is run before 3.11 (because Unpack doesn't exist). Not sure what the incantation is to make this test run only on 3.11+.
There was a problem hiding this comment.
I think that adding if sys.version_info >= (3, 11) around the entire test case should do the trick.
|
Diff from mypy_primer, showing the effect of this PR on open source code: spack (https://github.com/spack/spack) got 1.08x faster (80.9s -> 74.7s)
|
JukkaL
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking only for
typing_extensions.Unpack, which breaks code when checking at 3.11+ even if importingtyping_extensionsbecause its just a re-export fromtyping.These basic pythoneval tests also assert that the feature at least somewhat works with the real stubs - otherwise up until now we had basically no coverage of that, and were relying on the fake typing stubs to be close enough to the real thing.