Skip to content

Prefer exist_ok=True over explicit os.path.exists(...) checks #16642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Prefer exist_ok=True over explicit os.path.exists(...) checks #16642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mypy/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class AbstractReporter(metaclass=ABCMeta):
def __init__(self, reports: Reports, output_dir: str) -> None:
self.output_dir = output_dir
if output_dir != "<memory>":
stats.ensure_dir_exists(output_dir)
os.makedirs(output_dir, exist_ok=True)

@abstractmethod
def on_file(
Expand Down Expand Up @@ -737,7 +737,7 @@ def on_file(
if path.startswith(".."):
return
out_path = os.path.join(self.output_dir, "xml", path + ".xml")
stats.ensure_dir_exists(os.path.dirname(out_path))
os.makedirs(os.path.dirname(out_path), exist_ok=True)
last_xml.write(out_path, encoding="utf-8")

def on_finish(self) -> None:
Expand Down Expand Up @@ -782,7 +782,7 @@ def on_file(
if path.startswith(".."):
return
out_path = os.path.join(self.output_dir, "html", path + ".html")
stats.ensure_dir_exists(os.path.dirname(out_path))
os.makedirs(os.path.dirname(out_path), exist_ok=True)
transformed_html = bytes(self.xslt_html(last_xml, ext=self.param_html))
with open(out_path, "wb") as out_file:
out_file.write(transformed_html)
Expand Down
5 changes: 0 additions & 5 deletions mypy/stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,11 +477,6 @@ def is_complex(t: Type) -> bool:
return is_generic(t) or isinstance(t, (FunctionLike, TupleType, TypeVarType))


def ensure_dir_exists(dir: str) -> None:
if not os.path.exists(dir):
os.makedirs(dir)


def is_special_form_any(t: AnyType) -> bool:
return get_original_any(t).type_of_any == TypeOfAny.special_form

Expand Down
3 changes: 1 addition & 2 deletions mypy/stubgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1833,8 +1833,7 @@ def parse_options(args: list[str]) -> Options:
parser.error("Cannot specify both --parse-only/--no-analysis and --inspect-mode")

# Create the output folder if it doesn't already exist.
if not os.path.exists(ns.output_dir):
os.makedirs(ns.output_dir)
os.makedirs(ns.output_dir, exist_ok=True)

return Options(
pyversion=pyversion,
Expand Down