Bugfix 7514 #7515
Merged
Bugfix 7514 #7515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
Sorry for the long delay on this, but I think the same concern you had about the existing code had us confused too.
The new code looks good. A lot better than the old code.
From looking a bit at git blame I think that the original code predated Type and Union and so was expressed in a much less elegant way. The TypeType check got added last year and was done the way it was because it matched the code.
I think this is a nice improvement and the fact that it actually fixes bugs is gravy.
... but also maybe I'm wrong and there is something subtle here and I'll have to revert once we discover problems internally. But I don't think so.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7514