Skip to content

Fix type check failure stemming from new pytest release #9798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Fix type check failure stemming from new pytest release #9798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ flake8-bugbear; python_version >= '3.5'
flake8-pyi>=20.5; python_version >= '3.6'
lxml>=4.4.0
psutil>=4.0
pytest>=6.1.0,<7.0.0
# pytest 6.2 does not support Python 3.5
pytest>=6.1.0,<6.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t you select pre-6.2 for Python 3.5 only?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, oops... My urge to get things green was all consuming and I merged right before you posted this, sorry :-(
We definitely could, although in the past we've had to make changes to mypy source code based on pytest type annotation changes, so things are a little simpler if we stick to a single pytest version for all of mypy. Hopefully we can drop Python 3.5 support soon anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry that this declaration will stay behind even after we drop 3.5, and once we try to catch up with pytest we’d have a bunch of issues to debug all at once. But it’s fine, we can cross that bridge when we get to it.

pytest-xdist>=1.34.0,<2.0.0
pytest-forked>=1.3.0,<2.0.0
pytest-cov>=2.10.0,<3.0.0
Expand Down