Skip to content

Howto Unicode, part #2 #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 8, 2019
Merged

Howto Unicode, part #2 #807

merged 6 commits into from
Jun 8, 2019

Conversation

deronnax
Copy link
Collaborator

@deronnax deronnax commented Jun 2, 2019

Petite baisse d'inspiration sur la fin, vos observations sont les bienvenues.

Pospell s'étouffe sur "ss" et "Marc-", quelle est la solution élégante à ça ?

@JulienPalard
Copy link
Member

@deronnax Je viens de release pospell 0.3.4 qui fix le fait qu'il coupait le nom de Marc-André en deux. Tu peux whitelister Marc-André dans dict.

@JulienPalard
Copy link
Member

Pour ton problème de ss j'ai pas de solution élégante, on se rabbat sur l'italique si tu n'en trouve pas non plus ?

@JulienPalard JulienPalard added the NEED REVIEWER This PR needs a reviewer :) label Jun 2, 2019
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette très bonne contribution.

@JulienPalard JulienPalard added awaiting changes and removed NEED REVIEWER This PR needs a reviewer :) labels Jun 3, 2019
@deronnax
Copy link
Collaborator Author

deronnax commented Jun 5, 2019

J'ai intégré tous les changements de @christopheNan . N'il y a-t-il pas dans Github un moyen de marquer la review, les changes requested, comme completés, résolus ?

@JulienPalard
Copy link
Member

LGTM ! Merci @deronnax je merge !

@JulienPalard JulienPalard merged commit 4934add into python:3.7 Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants