Skip to content

Commit fc11e83

Browse files
authored
move two more allowlist entries to can't fix (#13247)
1 parent acebd50 commit fc11e83

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

stdlib/@tests/stubtest_allowlists/common.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ importlib.abc.PathEntryFinder.find_spec # Not defined on the actual class, but
2323
numbers.Number.__hash__ # typeshed marks this as abstract but code just sets this as None
2424
select.poll # Depends on configuration
2525
selectors.DevpollSelector # Depends on configuration
26-
shutil.rmtree # stubtest doesn't like that we have this as an instance of a callback protocol instead of a function
2726
socketserver.BaseServer.fileno # implemented in derived classes
2827
socketserver.BaseServer.get_request # implemented in derived classes
2928
socketserver.BaseServer.server_bind # implemented in derived classes
@@ -33,7 +32,6 @@ tkinter.simpledialog.[A-Z_]+
3332
tkinter.simpledialog.TclVersion
3433
tkinter.simpledialog.TkVersion
3534
tkinter.Text.count # stubtest somehow thinks that index1 parameter has a default value, but it doesn't in any of the overloads
36-
unittest.mock.patch # It's a complicated overload and I haven't been able to figure out why stubtest doesn't like it
3735
weakref.WeakKeyDictionary.update
3836
weakref.WeakValueDictionary.update
3937

@@ -446,6 +444,7 @@ os._wrap_close.writelines # Methods that come from __getattr__() at runtime
446444
pickle._Pickler\..* # Best effort typing for undocumented internals
447445
pickle._Unpickler\..* # Best effort typing for undocumented internals
448446
_?queue.SimpleQueue.__init__ # C signature is broader than what is actually accepted
447+
shutil.rmtree # function with attributes, which we approximate with a callable protocol
449448
ssl.PROTOCOL_SSLv2 # Depends on the existence and flags of SSL
450449
ssl.PROTOCOL_SSLv3 # Depends on the existence and flags of SSL
451450
sys.implementation # Actually SimpleNamespace but then you wouldn't have convenient attributes
@@ -568,6 +567,7 @@ unittest.runner._WritelnDecorator.write # Methods that come from __getattr__()
568567
urllib.response.addbase.write # Methods that come from __getattr__() at runtime
569568
urllib.response.addbase.writelines # Methods that come from __getattr__() at runtime
570569
urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ # Args are passed as is to super, so super args are specified
570+
unittest.mock.patch # function with attributes, which we approximate with a callable class
571571
_?weakref\.CallableProxyType\.__getattr__ # Should have all attributes of proxy
572572
_?weakref\.(ref|ReferenceType)\.__init__ # C implementation has incorrect signature
573573
_?weakref\.(ref|ReferenceType)\.__call__ # C function default annotation is wrong

0 commit comments

Comments
 (0)