Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Commit 9cce2b9

Browse files
drisspgfacebook-github-bot
authored andcommitted
Remove the xfails after Brian's multiple fake mode PR (#222)
Summary: This removes the xfails on the different tensor inputs and outputs to compiled regions. pytorch/pytorch#118191. Also makes the other xfails strict which will throw an error on unexpected pass Pull Request resolved: #222 Reviewed By: bdhirsh Differential Revision: D53954091 Pulled By: drisspg fbshipit-source-id: 45556adcb9354606e968ce439b802631ad4c0f46
1 parent 956195b commit 9cce2b9

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

test/conftest.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ def x_fail_activation_hooks(request):
66
use_activation_hooks = request.getfixturevalue("use_activation_hooks")
77
if use_activation_hooks:
88
request.node.add_marker(
9-
pytest.mark.xfail(reason="use_activation_hooks is not supported for AOT")
9+
pytest.mark.xfail(
10+
reason="use_activation_hooks is not supported for AOT", strict=True
11+
)
1012
)
1113

1214

@@ -16,5 +18,7 @@ def x_fail_activation_hooks_with_delayed(request):
1618
use_activation_hooks = request.getfixturevalue("use_activation_hooks")
1719
if use_activation_hooks and linear_type == linear_type.DELAYED:
1820
request.node.add_marker(
19-
pytest.mark.xfail(reason="use_activation_hooks is not supported for AOT")
21+
pytest.mark.xfail(
22+
reason="use_activation_hooks is not supported for AOT", strict=True
23+
)
2024
)

test/test_compile.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ def forward(self, x):
141141
return x_hp
142142
return x_fp8
143143

144-
@pytest.mark.xfail(reason="TODO: Fix this test, see TODO in MockLinear")
145144
def test_float8_with_graph_break_in_the_middle(self):
146145
"""Test that having Float8Tensor object at the boundary of a subgraph"""
147146
cnts = CompileCounterWithBackend("inductor")
@@ -174,7 +173,6 @@ def to_float(x):
174173
)
175174
torch.testing.assert_close(y2_eager, y2_compiled)
176175

177-
@pytest.mark.xfail(reason="TODO: Fix this test, see TODO in MockLinear")
178176
def test_float8_graph_output(self):
179177
"""Test that having Float8Tensor object as a graph output works"""
180178
cnts = CompileCounterWithBackend("inductor")

0 commit comments

Comments
 (0)