Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Commit e4f16f5

Browse files
committed
add comment on trying foreach
1 parent 336ef68 commit e4f16f5

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

float8_experimental/float8_linear_utils.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,8 @@ def sync_float8_amax_and_scale_history(model: torch.nn.Module, fp8_layers=None)
218218
reduced_fp8_amax_w_tensor,
219219
reduced_fp8_amax_dL_dY_tensor,
220220
) = torch.split(all_reduced_amax_tensor, len(fp8_amax_x_tensor_list))
221+
222+
# TODO foreach is not supported with AsyncCollectiveTensor
221223
for idx, child in enumerate(fp8_layers):
222224
child.fp8_amax_x.copy_(reduced_fp8_amax_tensor[idx])
223225
child.fp8_amax_w.copy_(reduced_fp8_amax_w_tensor[idx])

0 commit comments

Comments
 (0)