Skip to content

Commit 4143c07

Browse files
pzhan9facebook-github-bot
authored andcommitted
Use collect_commactor_routing_tree
Summary: This should be the right method since it simulate the comm actor part too. Reviewed By: shayne-fletcher Differential Revision: D75099703 fbshipit-source-id: f318503663ea3cb19bc38387db381b415dcdcd9b
1 parent af4bc3f commit 4143c07

File tree

1 file changed

+4
-8
lines changed
  • hyperactor_mesh/src/comm

1 file changed

+4
-8
lines changed

hyperactor_mesh/src/comm/mod.rs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ mod tests {
449449
use maplit::btreemap;
450450
use maplit::hashmap;
451451
use ndslice::selection;
452-
use ndslice::selection::test_utils::collect_routed_paths;
452+
use ndslice::selection::test_utils::collect_commactor_routing_tree;
453453
use test_utils::*;
454454
use timed_test::async_timed_test;
455455
use tracing::Level;
@@ -583,8 +583,8 @@ mod tests {
583583
// * verify all remaining ports are comm actor ports;
584584
// * remove the actor information and return a rank-based tree representation.
585585
//
586-
// The rank-based tree representation is what [collect_routed_paths] returns.
587-
// This conversion enables us to compare the path against [collect_routed_paths]'s result.
586+
// The rank-based tree representation is what [collect_commactor_routing_tree] returns.
587+
// This conversion enables us to compare the path against [collect_commactor_routing_tree]'s result.
588588
//
589589
// For example, for a 2x2 slice, the port tree could look like:
590590
// dest[0].comm[0][1028] -> [client[0].client_user[0][1025], dest[0].comm[0][1028]]
@@ -746,13 +746,9 @@ mod tests {
746746
{
747747
// Get the paths used in casting
748748
let sel_paths = PathToLeaves(
749-
collect_routed_paths(&uslice.selection, &uslice.slice)
749+
collect_commactor_routing_tree(&uslice.selection, &uslice.slice)
750750
.delivered
751751
.into_iter()
752-
.map(|(d, mut path)| {
753-
path.dedup();
754-
(d, path)
755-
})
756752
.collect(),
757753
);
758754

0 commit comments

Comments
 (0)