Skip to content

Commit bcd3511

Browse files
committed
fix: Raise error when registering Packet-keyed converter
- Packet-keyed converters are too error-prone, since new overloads could be added or existing overloads may have been overlooked
1 parent fe0d8e0 commit bcd3511

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ def aten_ops_hard_sigmoid(
296296
)
297297

298298

299-
@dynamo_tensorrt_converter(torch.ops.aten.matmul) # type: ignore[misc]
299+
@dynamo_tensorrt_converter(torch.ops.aten.matmul.default) # type: ignore[misc]
300300
@dynamo_tensorrt_converter(torch.ops.aten.mm.default) # type: ignore[misc]
301301
@dynamo_tensorrt_converter(torch.ops.aten.mv.default) # type: ignore[misc]
302302
def aten_ops_matmul(

py/torch_tensorrt/dynamo/conversion/converter_registry.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
cast,
1717
)
1818

19+
from torch._ops import OpOverloadPacket
1920
from torch.fx.node import Argument, Node, Target, _get_qualified_name
2021
from torch_tensorrt.fx.converter_registry import CONVERTERS
2122
from torch_tensorrt.fx.types import TRTNetwork, TRTTensor
@@ -101,6 +102,14 @@ def register_converter(converter: ConverterImplSignature) -> ConverterImplSignat
101102
capability_validator=capability_validator,
102103
)
103104

105+
if isinstance(key, OpOverloadPacket):
106+
raise AssertionError(
107+
f"Detected converter for OpOverloadPacket {key}. "
108+
"We do not support OpOverloadPacket-keyed converters. Make sure to "
109+
"explicitly specify each converter overload. For instance "
110+
"aten.mean is not a valid key, but aten.mean.default is."
111+
)
112+
104113
# If a converter for this operator already exists, append the new converter to the list
105114
# Otherwise, start a new list
106115
if key in DYNAMO_ATEN_CONVERTERS:

0 commit comments

Comments
 (0)