Skip to content

Commit d92a6f5

Browse files
committed
removing chunk op, changing the skip test message and remove the dynamic shape check of input in validator
1 parent 885046d commit d92a6f5

File tree

2 files changed

+5
-29
lines changed

2 files changed

+5
-29
lines changed

py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -692,9 +692,7 @@ def aten_ops_softmax(
692692

693693
@dynamo_tensorrt_converter(
694694
torch.ops.aten.split.Tensor,
695-
capability_validator=(
696-
has_static_shapes_in_args([0]) and has_static_shapes_in_args([1])
697-
),
695+
capability_validator=has_static_shapes_in_args([1]),
698696
supports_dynamic_shapes=True,
699697
)
700698
@dynamo_tensorrt_converter(
@@ -905,30 +903,6 @@ def aten_ops_slice(
905903
)
906904

907905

908-
@dynamo_tensorrt_converter(torch.ops.aten.chunk.default)
909-
@enforce_tensor_types(
910-
{
911-
0: (TRTTensor,),
912-
}
913-
)
914-
def aten_ops_chunk(
915-
ctx: ConversionContext,
916-
target: Target,
917-
args: Tuple[Argument, ...],
918-
kwargs: Dict[str, Argument],
919-
name: str,
920-
) -> Union[TRTTensor, Sequence[TRTTensor]]:
921-
return impl.slice.chunk(
922-
ctx,
923-
target,
924-
SourceIR.ATEN,
925-
name,
926-
args[0],
927-
args[1],
928-
args_bounds_check(args, 2, 0),
929-
)
930-
931-
932906
@dynamo_tensorrt_converter(torch.ops.aten.cumsum.default, supports_dynamic_shapes=True)
933907
@enforce_tensor_types(
934908
{

tests/py/dynamo/conversion/test_chunk_aten.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,10 @@ def forward(self, input):
8585

8686

8787
#######################Dynamic cases#######################
88-
#The tests are skipped for now. Will be addressed once https://github.com/pytorch/pytorch/issues/134663 is addressed
89-
@unittest.skip("Pending aten.split converter. Currently tested by E2E")
88+
# The tests are skipped for now. Will be addressed once https://github.com/pytorch/pytorch/issues/134663 is addressed
89+
@unittest.skip(
90+
"Pending aten.split dynamic input torch.export guard bug. Issue- https://github.com/pytorch/pytorch/issues/134663"
91+
)
9092
class TestChunkDynamicConverter(DispatchTestCase):
9193
@parameterized.expand(
9294
[

0 commit comments

Comments
 (0)