Skip to content

Commit b7d90f7

Browse files
williamwen42facebook-github-bot
authored andcommitted
remove #ops comparison to fx.symbolic_trace from dynamo standard_test (#112420)
Summary: Fix pytorch/pytorch#112230 by removing the comparison of number of ops in dynamo vs. fx.symbolic_trace. A number of tests fail in `test_functions.py` fail because the number of ops is no longer the same, but this seems to be acceptable behavior by dynamo. X-link: pytorch/pytorch#112420 Approved by: https://github.com/jansel, https://github.com/int3 Reviewed By: ZainRizvi Differential Revision: D50873069 Pulled By: williamwen42 fbshipit-source-id: f08463757e2a081ee504084fc3e4dea8d1ec7214
1 parent cdbfa9c commit b7d90f7

File tree

1 file changed

+0
-10
lines changed
  • userbenchmark/dynamo/dynamobench/_dynamo

1 file changed

+0
-10
lines changed

userbenchmark/dynamo/dynamobench/_dynamo/testing.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -249,16 +249,6 @@ def standard_test(self, fn, nargs, expected_ops=None, expected_ops_dynamic=None)
249249
expected_ops = expected_ops_dynamic
250250

251251
actual = CompileCounter()
252-
if expected_ops is None:
253-
expected = CompileCounter()
254-
try:
255-
gm = torch.fx.symbolic_trace(fn)
256-
expected(gm) # type: ignore[call-arg] # FIXME: https://github.com/pytorch/pytorch/issues/112230
257-
print("\nfx.symbolic_trace graph:")
258-
gm.graph.print_tabular()
259-
expected_ops = expected.op_count
260-
except Exception:
261-
pass # Silently ignore FX errors (not our issue)
262252

263253
args1 = [torch.randn(10, 10) for _ in range(nargs)]
264254
args2 = [torch.randn(10, 10) for _ in range(nargs)]

0 commit comments

Comments
 (0)