Skip to content

Commit 03b8b61

Browse files
larryliu0820facebook-github-bot
authored andcommitted
Fix oss buck build
Summary: We need to fix the following things in order to build: 1. properly link prelude to `.buckconfig` 2. add a shim version of `prelude/BUCK` in `shim/BUCK`, so that dependencies like `toolchains//:cxx` can find its way. 3. bring `env_interface.bzl` up-to-date. The internal version of it has more attributes and we need to keep them in sync. 4. patch .gitignore so it doesn't ignore any path containing `build/`, for example, `shim/xplat/executorch/build/` Reviewed By: cccclai, dbort Differential Revision: D47642414 fbshipit-source-id: a3803339b6fe7859035bdf4ceb41469aa0f7f0c7
1 parent 4788feb commit 03b8b61

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

.buckconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
[repositories]
88
root = .
9-
prelude = prelude
9+
prelude = third-party/prelude
1010
shim = shim
1111

1212
[repository_aliases]

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
build/
1+
buck-out/
22
executorch.egg-info
33
__pycache__/

shim/xplat/executorch/build/env_interface.bzl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ load(":type_defs.bzl", "is_list", "is_tuple")
1010

1111
_ET_TARGET_PREFIX = "executorch"
1212

13+
# Indicates that an external_dep entry should fall through to the underlying
14+
# buck rule.
15+
_EXTERNAL_DEP_FALLTHROUGH = "<fallthrough>"
16+
1317
_EXTERNAL_DEPS = {
1418
# ATen C++ library deps
1519
"aten-core": [], # TODO(larryliu0820): Add support
@@ -185,4 +189,5 @@ env = struct(
185189
remove_platform_specific_args = _remove_platform_specific_args,
186190
resolve_external_dep = _resolve_external_dep,
187191
target_needs_patch = _target_needs_patch,
192+
EXTERNAL_DEP_FALLTHROUGH = _EXTERNAL_DEP_FALLTHROUGH,
188193
)

0 commit comments

Comments
 (0)