change warning from pybindings around memory planned outputs (#2799)

JacobSzwejbka · facebook-github-bot · commit 06668cf507c4 · 2024-04-02T13:26:21.000-07:00
Summary: Pull Request resolved: #2799 People keep thinking this message was an error so trying to make it clear its more just info Reviewed By: cccclai Differential Revision: D55610831 fbshipit-source-id: ba613631e7bd796aca516e1631079ccbb03d6c32
diff --git a/extension/pybindings/pybindings.cpp b/extension/pybindings/pybindings.cpp
@@ -194,8 +194,8 @@ class Module final {
           // This can error if the outputs are already pre-allocated. Ignore
           // this error because it doesn't affect correctness, but log it.
           ET_LOG(
-              Error,
-              "ignoring error from set_output_data_ptr(): 0x%" PRIx32,
+              Info,
+              "Cannot set_output_data_ptr(): this likely means the outputs were MemoryPlanned inspect the error code to know for sure, but likely this is not an issue. 0x%" PRIx32,
               static_cast<uint32_t>(output_status));
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -194,8 +194,8 @@ class Module final {`
`194`	`194`	`// This can error if the outputs are already pre-allocated. Ignore`
`195`	`195`	`// this error because it doesn't affect correctness, but log it.`
`196`	`196`	`ET_LOG(`
`197`		`- Error,`
`198`		`- "ignoring error from set_output_data_ptr(): 0x%" PRIx32,`
	`197`	`+ Info,`
	`198`	`+ "Cannot set_output_data_ptr(): this likely means the outputs were MemoryPlanned inspect the error code to know for sure, but likely this is not an issue. 0x%" PRIx32,`
`199`	`199`	`static_cast<uint32_t>(output_status));`
`200`	`200`	`}`
`201`	`201`	`}`