Skip to content

Commit 06a9fa5

Browse files
committed
Update on "[ET-VK] Integrate axis mapping into staging <-> buffer transfer shaders"
## Context Building on the previous diff, this diff integrates axis mapping into staging <-> buffer transfer shaders. Alternative versions of indexing utility functions are introduced to account for axis mapping. The impact of shader latency of using axis mapping on transfer shaders is examined in the next diff. Differential Revision: [D62210117](https://our.internmc.facebook.com/intern/diff/D62210117/) [ghstack-poisoned]
2 parents eb6d388 + 7535ad3 commit 06a9fa5

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

backends/vulkan/test/vulkan_compute_api_test.cpp

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1007,10 +1007,16 @@ TEST_F(VulkanComputeAPITest, print_object_sizes) {
10071007
// The actual sizes of each object is dependent on the platform. However, we
10081008
// can alert ourselves to any significant changes in the sizes of these
10091009
// objects by checking the `sizeof()` the class against some loose thresholds.
1010-
EXPECT_TRUE(sizeof(vTensor) < 1800);
1011-
EXPECT_TRUE(sizeof(Value) < 2400);
1010+
1011+
// Current known size on 64 bit system: 1824 B
1012+
EXPECT_TRUE(sizeof(vTensor) < 2000);
1013+
// Current known size on 64 bit system: 1840 B
1014+
EXPECT_TRUE(sizeof(Value) < 2200);
1015+
// Current known size on 64 bit system: 240 B
10121016
EXPECT_TRUE(sizeof(StagingBuffer) < 500);
1017+
// Current known size on 64 bit system: 384 B
10131018
EXPECT_TRUE(sizeof(ComputeGraph) < 500);
1019+
// Current known size on 64 bit system: 248 B
10141020
EXPECT_TRUE(sizeof(ExecuteNode) < 500);
10151021
}
10161022

0 commit comments

Comments
 (0)