Skip to content

Commit 0caa70e

Browse files
huydhnfacebook-github-bot
authored andcommitted
Checkout submodules and install lld linker (#17)
Summary: There are the some missing steps to run buck2. #18 needs this. ### Testing Manually login to the runner, go to the docker container and run the following steps: ``` cd third-party/prelude git checkout 971986683b987d399473969831bca6338833736d <-- the working prelude commit buck2 build //test:size_test_all_ops ``` Pull Request resolved: #17 Test Plan: Testing on GitHub OSS CI https://github.com/pytorch/executorch/actions/runs/5651014889/job/15308367688?pr=17 Reviewed By: larryliu0820 Differential Revision: D47741878 Pulled By: huydhn fbshipit-source-id: e8a698bd03cf2db5d9018448665571c42aa90400
1 parent 053c2de commit 0caa70e

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

.ci/docker/common/install_clang.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ install_ubuntu() {
77

88
apt-get install -y --no-install-recommends clang-"$CLANG_VERSION"
99
apt-get install -y --no-install-recommends llvm-"$CLANG_VERSION"
10+
# Also require LLD linker from llvm
11+
apt-get install -y lld
1012

1113
# Use update-alternatives to make this version the default
1214
update-alternatives --install /usr/bin/clang clang /usr/bin/clang-"$CLANG_VERSION" 50

.github/workflows/pull.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919
runner: linux.2xlarge
2020
docker-image: executorch-ubuntu-22.04-clang12
2121
fetch-depth: 0
22+
submodules: 'true'
2223
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
2324
script: |
2425
WORKSPACE=$(pwd)
@@ -28,6 +29,7 @@ jobs:
2829
ln -s "${WORKSPACE}" executorch
2930
# Install executorch
3031
source executorch/install.sh
32+
popd
3133
3234
# Just print out the list of packages for debugging
3335
pip list

0 commit comments

Comments
 (0)