Skip to content

Commit 12ed282

Browse files
JacobSzwejbkafacebook-github-bot
authored andcommitted
flag a bunch of method functions as deprecated
Summary: None of these should exist in the public API, but we are out of time before MVP so just deprecating Differential Revision: D49747135 fbshipit-source-id: 5cb2a88f8ccfc8a0d7124327e7cb16556dff7dae
1 parent 620b769 commit 12ed282

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

runtime/executor/method.h

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -196,17 +196,25 @@ class Method final {
196196
*/
197197
__ET_NODISCARD Error experimental_reset_execution();
198198

199-
size_t values_size() const;
200-
const EValue& get_value(size_t i) const;
201-
EValue& mutable_value(size_t i);
199+
__ET_DEPRECATED size_t values_size() const;
200+
__ET_DEPRECATED const EValue& get_value(size_t i) const;
201+
__ET_DEPRECATED EValue& mutable_value(size_t i);
202202
size_t inputs_size() const;
203-
size_t get_input_index(size_t i) const;
204-
const EValue& get_input(size_t i) const;
205-
EValue& mutable_input(size_t i);
203+
/// DEPRECATED: Use MethodMeta instead to access metadata, and set_input to
204+
/// update Method inputs.
205+
__ET_DEPRECATED size_t get_input_index(size_t i) const;
206+
/// DEPRECATED: Use MethodMeta instead to access metadata, and set_input to
207+
/// update Method inputs.
208+
__ET_DEPRECATED const EValue& get_input(size_t i) const;
209+
/// DEPRECATED: Use MethodMeta instead to access metadata, and set_input to
210+
/// update Method inputs.
211+
__ET_DEPRECATED EValue& mutable_input(size_t i);
206212
size_t outputs_size() const;
207-
size_t get_output_index(size_t i) const;
213+
__ET_DEPRECATED size_t get_output_index(size_t i) const;
208214
const EValue& get_output(size_t i) const;
209-
EValue& mutable_output(size_t i);
215+
/// DEPRECATED: Use MethodMeta instead to access metadata, and get_output to
216+
/// retrieve Method outputs.
217+
__ET_DEPRECATED EValue& mutable_output(size_t i);
210218
~Method();
211219

212220
private:

0 commit comments

Comments
 (0)