Skip to content

Commit 16a892d

Browse files
bigfootjonfacebook-github-bot
authored andcommitted
Improve homebrew header times (#3695)
Summary: Pull Request resolved: #3695 This speeds up loading homebrew packages X-link: facebook/folly#2210 Reviewed By: yfeldblum Differential Revision: D57634166 Pulled By: bigfootjon fbshipit-source-id: e3e4d0f358a9501fc7e5e7b2bcb75924c8e38ab5
1 parent ab1c8aa commit 16a892d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

shim/third-party/third_party.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def homebrew_library(
2828
name = brew_headers,
2929
default_target_platform = default_target_platform,
3030
out = "out",
31-
cmd = "cp -r `brew --prefix {}`/{} $OUT || echo Looks like you need to run: brew install {}".format(package_name, header_path or "include", package_name),
31+
cmd = "echo \"-I`brew --prefix {}`/{}\" > $OUT".format(package_name, header_path or "include"),
3232
)
3333

3434
# @lint-ignore BUCKLINT
@@ -46,8 +46,8 @@ def homebrew_library(
4646
name = name or package_name,
4747
default_target_platform = default_target_platform,
4848
visibility = visibility,
49-
header_dirs = [":{}".format(brew_headers)],
5049
exported_deps = deps,
50+
exported_preprocessor_flags = ["@$(location :{})".format(brew_headers)],
5151
linker_flags = linker_flags,
5252
labels = labels,
5353
)

0 commit comments

Comments
 (0)