Skip to content

Commit 1735a20

Browse files
author
yifan_shen3
committed
try fix CI: 1. pin coremltools 8.0b2; 2. refrain from defaulting stateful llama until CI machine upgraded to MacOS 15
1 parent c20ef9f commit 1735a20

File tree

3 files changed

+2
-14
lines changed

3 files changed

+2
-14
lines changed

backends/apple/coreml/scripts/install_requirements.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ rm -rf "$COREML_DIR_PATH/third-party"
2424
mkdir "$COREML_DIR_PATH/third-party"
2525

2626
echo "${green}ExecuTorch: Cloning coremltools."
27-
git clone --depth 1 --branch 8.0b1 "https://github.com/apple/coremltools.git" $COREMLTOOLS_DIR_PATH
27+
git clone --depth 1 --branch 8.0b2 "https://github.com/apple/coremltools.git" $COREMLTOOLS_DIR_PATH
2828
cd $COREMLTOOLS_DIR_PATH
2929

3030
STATUS=$?

backends/apple/coreml/test/test_coreml_partitioner.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
import executorch.exir
1010

11-
import pytest
12-
1311
import torch
1412
import torchvision
1513

@@ -91,10 +89,6 @@ def test_vit_skip_conv(self):
9189
if node.op == "call_function"
9290
] == total
9391

94-
@pytest.mark.skipif(
95-
"b" in ct.__version__ or ct.__version__ < "8.0",
96-
reason="coremltools 8.0 or higher is required",
97-
)
9892
def test_buffer(self):
9993
embedding_dim = 3
10094
max_seq_len = 2

examples/models/llama2/export_llama_lib.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -281,13 +281,7 @@ def build_args_parser() -> argparse.ArgumentParser:
281281
parser.add_argument("-V", "--vulkan", action="store_true")
282282
parser.add_argument("--mps", action="store_true")
283283
parser.add_argument("--coreml", action="store_true")
284-
parser.add_argument(
285-
"--coreml-disable-state",
286-
dest="coreml_enable_state",
287-
default=True, # Enable this by default
288-
action="store_false",
289-
help="Delegate mutable buffer to Core ML state",
290-
)
284+
parser.add_argument("--coreml-enable-state", action="store_true")
291285
parser.add_argument(
292286
"--qnn",
293287
action="store_true",

0 commit comments

Comments
 (0)