Skip to content

Commit 1782ded

Browse files
committed
Fix tests
1 parent 8b032dd commit 1782ded

File tree

6 files changed

+46
-97
lines changed

6 files changed

+46
-97
lines changed

Test.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ if(BUILD_TESTING)
1515
add_subdirectory(extension/memory_allocator/test)
1616
add_subdirectory(extension/parallel/test)
1717
add_subdirectory(extension/pytree/test)
18-
add_subdirectory(kernels/portable/test)
1918
add_subdirectory(kernels/portable/cpu/util/test)
2019
add_subdirectory(kernels/prim_ops/test)
2120
add_subdirectory(kernels/test)

kernels/portable/test/CMakeLists.txt

Lines changed: 0 additions & 43 deletions
This file was deleted.

kernels/quantized/CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,3 @@ install(
153153
DESTINATION lib
154154
PUBLIC_HEADER DESTINATION include/executorch/kernels/quantized/
155155
)
156-
157-
if(BUILD_TESTING)
158-
add_subdirectory(test)
159-
endif()

kernels/quantized/test/CMakeLists.txt

Lines changed: 0 additions & 44 deletions
This file was deleted.

kernels/test/CMakeLists.txt

Lines changed: 43 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ set(EXECUTORCH_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../..)
1717

1818
include(${EXECUTORCH_ROOT}/build/Test.cmake)
1919

20-
set(_kernels portable optimized)
20+
set(_kernels portable optimized quantized)
2121

2222
foreach(kernel ${_kernels})
2323
set(_wrapper_dir
@@ -50,6 +50,12 @@ foreach(kernel ${_kernels})
5050
COMMENT "Generating ${_wrapper_dir}/supported_features.cpp and header"
5151
VERBATIM
5252
)
53+
54+
file(COPY
55+
"${CMAKE_CURRENT_BINARY_DIR}/../../kernels/${kernel}/${kernel}_ops_lib/Functions.h"
56+
"${CMAKE_CURRENT_BINARY_DIR}/../../kernels/${kernel}/${kernel}_ops_lib/NativeFunctions.h"
57+
"${CMAKE_CURRENT_BINARY_DIR}/../../kernels/${kernel}/${kernel}_ops_lib/RegisterKernels.h"
58+
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/include/${kernel}/executorch/kernels/${kernel}/")
5359
endforeach()
5460

5561
add_custom_target(
@@ -214,6 +220,9 @@ set(all_test_sources
214220
set(_portable_kernels_test_sources
215221
${all_test_sources}
216222
${CMAKE_CURRENT_BINARY_DIR}/include/portable/executorch/kernels/test/supported_features.cpp
223+
"${EXECUTORCH_ROOT}/kernels/portable/test/op_div_test.cpp"
224+
"${EXECUTORCH_ROOT}/kernels/portable/test/op_gelu_test.cpp"
225+
"${EXECUTORCH_ROOT}/kernels/portable/test/op_mul_test.cpp"
217226
)
218227

219228
et_cxx_test(
@@ -223,7 +232,6 @@ et_cxx_test(
223232
add_dependencies(portable_kernels_test generate_wrapper)
224233
target_include_directories(
225234
portable_kernels_test PRIVATE "${CMAKE_CURRENT_BINARY_DIR}/include/portable"
226-
"${CMAKE_INSTALL_PREFIX}/include"
227235
)
228236

229237
set(_optimized_kernels_test_sources
@@ -265,3 +273,36 @@ target_include_directories(
265273
optimized_kernels_test PRIVATE "${CMAKE_CURRENT_BINARY_DIR}/include/optimized"
266274
"${CMAKE_INSTALL_PREFIX}/include"
267275
)
276+
277+
if(TARGET quantized_kernels)
278+
set(_quantized_kernels_test_sources
279+
"${EXECUTORCH_ROOT}/kernels/quantized/test/op_add_test.cpp"
280+
"${EXECUTORCH_ROOT}/kernels/quantized/test/op_choose_qparams_test.cpp"
281+
"${EXECUTORCH_ROOT}/kernels/quantized/test/op_embedding2b_test.cpp"
282+
"${EXECUTORCH_ROOT}/kernels/quantized/test/op_embedding4b_test.cpp"
283+
"${EXECUTORCH_ROOT}/kernels/quantized/test/op_embedding_test.cpp"
284+
"${EXECUTORCH_ROOT}/kernels/quantized/test/op_mixed_linear_test.cpp"
285+
"${EXECUTORCH_ROOT}/kernels/quantized/test/op_mixed_mm_test.cpp"
286+
"${EXECUTORCH_ROOT}/kernels/quantized/test/op_quantize_test.cpp"
287+
)
288+
289+
et_cxx_test(
290+
quantized_kernels_test
291+
SOURCES
292+
${_quantized_kernels_test_sources}
293+
EXTRA_LIBS
294+
cpuinfo
295+
extension_threadpool
296+
quantized_kernels
297+
quantized_ops_lib
298+
portable_kernels
299+
portable_ops_lib
300+
pthreadpool
301+
eigen_blas
302+
)
303+
add_dependencies(quantized_kernels_test generate_wrapper)
304+
target_include_directories(
305+
quantized_kernels_test PRIVATE "${CMAKE_CURRENT_BINARY_DIR}/include/quantized"
306+
"${CMAKE_CURRENT_BINARY_DIR}/include/portable"
307+
)
308+
endif()

runtime/kernel/test/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ target_link_libraries(
2323
operator_registry_test GTest::gtest GTest::gtest_main GTest::gmock executorch
2424
)
2525
target_include_directories(operator_registry_test PRIVATE ${EXECUTORCH_ROOT}/..)
26-
add_test(ExecuTorchTest operator_registry_test)
26+
add_test(operator_registry_test operator_registry_test)
2727

2828
add_executable(kernel_runtime_context_test kernel_runtime_context_test.cpp)
2929
target_link_libraries(
@@ -33,7 +33,7 @@ target_link_libraries(
3333
target_include_directories(
3434
kernel_runtime_context_test PRIVATE ${EXECUTORCH_ROOT}/..
3535
)
36-
add_test(ExecuTorchTest kernel_runtime_context_test)
36+
add_test(kernel_runtime_context_test kernel_runtime_context_test)
3737

3838
add_executable(
3939
operator_registry_max_kernel_num_test
@@ -55,7 +55,7 @@ target_compile_definitions(
5555
target_include_directories(
5656
operator_registry_max_kernel_num_test PRIVATE ${EXECUTORCH_ROOT}/..
5757
)
58-
add_test(ExecuTorchTest operator_registry_max_kernel_num_test)
58+
add_test(operator_registry_max_kernel_num_test operator_registry_max_kernel_num_test)
5959

6060
# TODO: Migrate kernel_double_registration_test and
6161
# test_kernel_manual_registration. Make sure dtype selective build is working.

0 commit comments

Comments
 (0)