Remove direct calls to serialize_to_flatbuffer

Summary: Users should prefer `to_executorch().buffer`.

Reviewed By: JacobSzwejbka

Differential Revision: D48366595

fbshipit-source-id: 9db517cd33c0493729be049fec6f9f3a359fd1cb

Author: dbort

backends/vulkan/test/TARGETS

@@ -15,7 +15,6 @@ python_unittest(
         "//executorch/backends/vulkan:vulkan_preprocess",
         "//executorch/exir:lib",
         "//executorch/exir/backend:backend_api",
-        "//executorch/exir/serialize:lib",
         "//executorch/extension/pybindings:portable",  # @manual
         "//executorch/extension/pytree:pylib",
         "//executorch/kernels/portable:custom_ops_generated_lib",

backends/vulkan/test/test_vulkan_delegate.py

@@ -13,9 +13,9 @@
 
 # import the vulkan backend implementation
 from executorch.backends.vulkan.vulkan_preprocess import VulkanBackend
-from executorch.exir.backend.backend_api import to_backend
 
-from executorch.exir.serialize import serialize_to_flatbuffer
+from executorch.exir import ExecutorchProgram
+from executorch.exir.backend.backend_api import to_backend
 
 ctypes.CDLL("libvulkan.so.1")
 
@@ -72,24 +72,21 @@ def __init__(self):
             def forward(self, *args):
                 return self.one_module(*args)
 
-        program = (
+        executorch_program: ExecutorchProgram = (
             exir.capture(WrappedModule(), sample_inputs, exir.CaptureConfig())
             .to_edge()
             .to_executorch()
-            .program
         )
 
         # Assert the backend name is vulkan
         self.assertEqual(
-            program.execution_plan[0].delegates[0].id,
+            executorch_program.program.execution_plan[0].delegates[0].id,
             VulkanBackend.__name__,
         )
 
-        buffer = serialize_to_flatbuffer(program)
-
         # Test the model with executor
-        # pyre-ignore
-        executorch_module = _load_for_executorch_from_buffer(buffer)
+        # pyre-ignore[16]: Module `executorch.extension.pybindings` has no attribute `portable`.
+        executorch_module = _load_for_executorch_from_buffer(executorch_program.buffer)
         # pyre-fixme[16]: Module `pytree` has no attribute `tree_flatten`.
         inputs_flattened, _ = tree_flatten(sample_inputs)
 

profiler/test/test_profiler_e2e.py

@@ -13,10 +13,7 @@
 
 import torch
 
-# torch.ops.load_library("//executorch/kernels/portable:custom_ops_generated_lib")
-
 from executorch import exir
-from executorch.exir.serialize import serialize_to_flatbuffer
 
 # pyre-ignore: Undefined import [21]: Could not find a module corresponding to import `executorch.extension.pybindings.portable`.
 from executorch.extension.pybindings.portable import (
@@ -51,10 +48,16 @@ class TestCustomOps(unittest.TestCase):
     def setUpClass(cls) -> None:
         model = Module()
         inputs = (torch.ones(2, 2, dtype=torch.float),)
-        program = exir.capture(model, inputs).to_edge().to_executorch().program
-        cls.flatbuff_without_stacktrace = serialize_to_flatbuffer(program)
+
+        # The serialized program file. This must live longer than cls.module,
+        # because the C++ pybindings will have a pointer to it. But none of the
+        # tests should need to touch it.
+        cls.__buffer: bytes = (
+            exir.capture(model, inputs).to_edge().to_executorch().buffer
+        )
+
         # pyre-ignore: Undefined attribute [16]: Module `executorch.extension.pybindings` has no attribute `portable`.
-        cls.module = _load_for_executorch_from_buffer(cls.flatbuff_without_stacktrace)
+        cls.module = _load_for_executorch_from_buffer(cls.__buffer)
 
         # pyre-fixme[16]: Module `pytree` has no attribute `tree_flatten`.
         cls.inputs_flattened, _ = tree_flatten(inputs)

test/end2end/test_end2end.py

@@ -45,7 +45,6 @@
     ToOutVarPass,
 )
 from executorch.exir.print_program import pretty_print, print_program
-from executorch.exir.serialize import serialize_to_flatbuffer
 from executorch.exir.tensor import make_tensor_value, TensorSpec
 from executorch.exir.tests.control_flow_models import (
     FTCondBasic,