Skip to content

Commit 1cd3b5c

Browse files
author
Github Executorch
committed
Update on "Add c10::irange to ExecuTorch"
irange is a header-only utility that is both more readable than the usual way to write for loops and also solves -Wsign-compare issues. I've previously vetted that it generates the same assembly as a regular for loop. Differential Revision: [D69817195](https://our.internmc.facebook.com/intern/diff/D69817195/) [ghstack-poisoned]
2 parents 936eabe + 05e43dc commit 1cd3b5c

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed
Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
1-
We added an extra c10 directory so that runtime/core/portable_type/c10
1+
This directory contains header files from `c10` in PyTorch core that
2+
need to be used in ExecuTorch core. They are copied here rather than
3+
being found through the torch pip package to keep the core build
4+
hermetic for embedded use cases. The headers should be exact copies
5+
from PyTorch core; if they are out of sync, please send a PR!
6+
7+
We added an extra c10 directory so that `runtime/core/portable_type/c10`
28
can be the directory to put on your include path, rather than
3-
runtime/core/portable_type, because using runtime/core/portable_type
9+
`runtime/core/portable_type`, because using `runtime/core/portable_type`
410
would cause all headers in that directory to be includeable with
511
`#include <foo.h>`. In particular, that includes
6-
runtime/core/portable_type/complex.h, which would shadow the C99
7-
complex.h standard header.
12+
`runtime/core/portable_type/complex.h`, which would shadow the C99
13+
`complex.h` standard header.

0 commit comments

Comments
 (0)