Skip to content

Commit 1da5168

Browse files
Rename "topic: not user facing" (#10828)
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #10791 by @jackzhxng ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/jackzhxng/6/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/jackzhxng/6/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/jackzhxng/6/orig @diff-train-skip-merge Co-authored-by: Jack Zhang <[email protected]>
1 parent 27e159e commit 1da5168

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/scripts/label_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@
2222

2323
LABEL_ERR_MSG_TITLE = "This PR needs a `release notes:` label"
2424
LABEL_ERR_MSG = f"""# {LABEL_ERR_MSG_TITLE}
25-
If your changes are user facing and intended to be a part of release notes, please use a label starting with `release notes:`.
25+
If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with `release notes:`.
2626
27-
If not, please add the `topic: not user facing` label.
27+
If not, please add the `release notes: none` label.
2828
2929
To add a label, you can comment to pytorchbot, for example
30-
`@pytorchbot label "topic: not user facing"`
30+
`@pytorchbot label "release notes: none"`
3131
3232
For more information, see
3333
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.
@@ -115,7 +115,7 @@ def has_required_labels(pr: "GitHubPR") -> bool:
115115
pr_labels = pr.get_labels()
116116
# Check if PR is not user facing
117117
is_not_user_facing_pr = any(
118-
label.strip() == "topic: not user facing" for label in pr_labels
118+
label.strip() == "release notes: none" for label in pr_labels
119119
)
120120
return is_not_user_facing_pr or any(
121121
label.strip() in get_release_notes_labels(pr.org, pr.project)

0 commit comments

Comments
 (0)