Skip to content

Commit 2be4e94

Browse files
authored
remove llava from test-models-linux (#8702)
See comment for explanation -- already have test-llava-runner-linux
1 parent df8ad7d commit 2be4e94

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.ci/scripts/gather_test_models.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,12 @@ def model_should_run_on_target_os(model: str, target_os: str) -> bool:
104104
For example, a big model can be disabled in macos due to the limited macos resources.
105105
"""
106106
if target_os == "macos":
107+
# Disabled in macos due to limited resources, and should stay that way even if
108+
# we otherwise re-enable.
107109
return model not in ["llava"]
108-
return True
110+
# Disabled globally because we have test-llava-runner-linux that does a more
111+
# comprehensive E2E test of llava.
112+
return model not in ["llava"]
109113

110114

111115
def export_models_for_ci() -> dict[str, dict]:

0 commit comments

Comments
 (0)