Skip to content

Commit 2c97516

Browse files
dbortfacebook-github-bot
authored andcommitted
Delete the unused TestMemoryConfig target (#390)
Summary: Pull Request resolved: #390 pybindings was the only target depending on this, but it didn't actually use it. Noticed this while tracking down users of the non-span HierarchicalAllocator ctor. ghstack-source-id: 201128783 exported-using-ghexport Reviewed By: tarun292 Differential Revision: D49344929 fbshipit-source-id: 7435c75b554deb3a11e91d2ec9727ff6b82db7d3
1 parent e1719b8 commit 2c97516

File tree

4 files changed

+0
-121
lines changed

4 files changed

+0
-121
lines changed

extension/pybindings/pybindings.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
#include <executorch/runtime/platform/profiler.h>
2727
#include <executorch/runtime/platform/runtime.h>
2828
#include <executorch/schema/bundled_program_schema_generated.h>
29-
#include <executorch/util/TestMemoryConfig.h>
3029
#include <executorch/util/bundled_program_verification.h>
3130
#include <executorch/util/read_file.h>
3231

shim/xplat/executorch/extension/pybindings/pybindings.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ PORTABLE_MODULE_DEPS = [
1818
"//executorch/extension/data_loader:buffer_data_loader",
1919
"//executorch/extension/data_loader:mmap_data_loader",
2020
"//executorch/extension/memory_allocator:malloc_memory_allocator",
21-
"//executorch/util:test_memory_config",
2221
"//executorch/util:util",
2322
"//executorch/runtime/executor/test:test_backend_compiler_lib",
2423
] + get_all_cpu_backend_targets()
@@ -32,7 +31,6 @@ ATEN_MODULE_DEPS = [
3231
"//executorch/extension/data_loader:mmap_data_loader",
3332
"//executorch/extension/memory_allocator:malloc_memory_allocator",
3433
"//executorch/util:read_file",
35-
"//executorch/util:test_memory_config",
3634
"//executorch/util:bundled_program_verification_aten",
3735
"//caffe2:torch",
3836
"//caffe2:torch_extension",

util/TestMemoryConfig.h

Lines changed: 0 additions & 104 deletions
This file was deleted.

util/targets.bzl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,6 @@ def define_common_targets():
77
TARGETS and BUCK files that call this function.
88
"""
99

10-
runtime.cxx_library(
11-
name = "test_memory_config",
12-
srcs = [],
13-
exported_headers = ["TestMemoryConfig.h"],
14-
visibility = [
15-
"//executorch/...",
16-
"@EXECUTORCH_CLIENTS",
17-
],
18-
deps = [
19-
"//executorch/runtime/core:core",
20-
"//executorch/runtime/core:memory_allocator",
21-
],
22-
)
23-
2410
runtime.cxx_library(
2511
name = "read_file",
2612
srcs = ["read_file.cpp"],

0 commit comments

Comments
 (0)