Skip to content

Commit 2e8b7de

Browse files
committed
Update on "[llava] Use huggingface LLaVA instead of depending on third-party/LLaVa"
Currently we depend on third-party/LLaVA for llava model definition. This is hard to use because we have to pull LLaVA in as a git submodule and install from there. It also breaks a lot of dependency assumptions. This PR removes `third-party/LLaVA`, in favor of huggingface llava model definition. Differential Revision: [D61200610](https://our.internmc.facebook.com/intern/diff/D61200610) [ghstack-poisoned]
1 parent 87a3a8b commit 2e8b7de

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

examples/models/llava/test/test_llava.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,4 +139,4 @@ def test_llava_export(self):
139139
torch.tensor([new_tokens]), skip_special_tokens=True
140140
)[0].strip()
141141
print(outputs)
142-
self.assertEqual(new_tokens.size(), 5)
142+
self.assertEqual(len(new_tokens), 5)

0 commit comments

Comments
 (0)