@@ -114,7 +114,7 @@ jobs:
114
114
# so let's just sed it
115
115
sed -i -e 's,{{ model_path }},'"${MODEL_PATH}"',g' default-ios-device-farm-appium-test-spec.yml.j2
116
116
117
- BENCHMARK_CONFIG_ID="${{ matrix.model }}_${{ matrix.config }}"
117
+ BENCHMARK_CONFIG_ID=$(echo "${{ matrix.model }}_${{ matrix.config }}" | sed -e 's/[^A-Za-z0-9._-]/_/g')
118
118
# The config for this benchmark runs, we save it in the test spec so that it can be fetched
119
119
# later by the upload script
120
120
sed -i -e 's,{{ benchmark_config_id }},'"${BENCHMARK_CONFIG_ID}"',g' default-ios-device-farm-appium-test-spec.yml.j2
@@ -123,10 +123,9 @@ jobs:
123
123
# Just print the test spec for debugging
124
124
cat default-ios-device-farm-appium-test-spec.yml
125
125
126
- BENCHMARK_CONFIG_FILENAME=$(echo "${BENCHMARK_CONFIG_ID}" | sed -e 's/[^A-Za-z0-9._-]/_/g')
127
126
# Save the benchmark configs so that we can use it later in the dashboard
128
- echo "${BENCHMARK_CONFIG}" > "${BENCHMARK_CONFIG_FILENAME }.json"
129
- echo "benchmark-config-filename =${BENCHMARK_CONFIG_FILENAME }" >> $GITHUB_OUTPUT
127
+ echo "${BENCHMARK_CONFIG}" > "${BENCHMARK_CONFIG_ID }.json"
128
+ echo "benchmark-config-id =${BENCHMARK_CONFIG_ID }" >> $GITHUB_OUTPUT
130
129
131
130
- name : Upload the spec
132
131
uses : seemethere/upload-artifact-s3@v5
@@ -146,7 +145,7 @@ jobs:
146
145
${{ github.repository }}/${{ github.run_id }}/artifacts/benchmark-configs/
147
146
retention-days : 1
148
147
if-no-files-found : error
149
- path : extension/benchmark/apple/Benchmark/${{ steps.prepare.outputs.benchmark-config-filename }}.json
148
+ path : extension/benchmark/apple/Benchmark/${{ steps.prepare.outputs.benchmark-config-id }}.json
150
149
151
150
export-models :
152
151
name : export-models
0 commit comments