Skip to content

Commit 36e66d8

Browse files
larryliu0820malfet
authored andcommitted
Update run-readme-pr.yml (#705)
* Update run-readme-pr.yml * Update run-readme-pr-macos.yml Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Replace tokenizer path as well Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
1 parent 57d2cd4 commit 36e66d8

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

.github/workflows/run-readme-pr-macos.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
name: Run the README instructions - with stories - on MacOS
2-
on:
1+
name: Run the README instructions - with stories - on MacOS
2+
on:
33
pull_request:
44
push:
55
branches:
@@ -26,20 +26,20 @@ jobs:
2626
# as this script does not isntall anything into conda env but rather as system dep
2727
pip3 uninstall -y torch || true
2828
set -eou pipefail
29-
29+
3030
echo "::group::Print machine info"
3131
uname -a
3232
sysctl machdep.cpu.brand_string
3333
sysctl machdep.cpu.core_count
3434
echo "::endgroup::"
35-
35+
3636
# echo "::group::Install newer objcopy that supports --set-section-alignment"
3737
# yum install -y devtoolset-10-binutils
3838
# export PATH=/opt/rh/devtoolset-10/root/usr/bin/:$PATH
3939
# echo "::endgroup::"
40-
40+
4141
echo "::group::Create script"
42-
python3 scripts/updown.py --file README.md --replace llama3:stories15M --suppress huggingface-cli,HF_TOKEN > ./we-run-this.sh
42+
python3 scripts/updown.py --file README.md --replace 'llama3:stories15M,-l 3:-l 2,meta-llama/Meta-Llama-3-8B-Instruct:stories15M' --suppress huggingface-cli,HF_TOKEN > ./we-run-this.sh
4343
# for good measure, if something happened to updown processor,
4444
# and it did not error out, fail with an exit 1
4545
echo "exit 1" >> ./we-run-this.sh
@@ -50,8 +50,7 @@ jobs:
5050
cat ./we-run-this.sh
5151
echo "*******************************************"
5252
bash -x ./we-run-this.sh
53-
53+
5454
echo "tests complete"
5555
echo "*******************************************"
5656
echo "::endgroup::"
57-

.github/workflows/run-readme-pr.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Run the README instructions - with stories
1+
name: Run the README instructions - with stories
22

33
on:
44
pull_request:
@@ -26,7 +26,7 @@ jobs:
2626
# echo "::endgroup::"
2727
2828
echo "::group::Create script"
29-
python3 scripts/updown.py --file README.md --replace llama3:stories15M --suppress huggingface-cli,HF_TOKEN > ./we-run-this.sh
29+
python3 scripts/updown.py --file README.md --replace 'llama3:stories15M,-l 3:-l 2,meta-llama/Meta-Llama-3-8B-Instruct:stories15M' --suppress huggingface-cli,HF_TOKEN > ./we-run-this.sh
3030
# for good measure, if something happened to updown processor,
3131
# and it did not error out, fail with an exit 1
3232
echo "exit 1" >> ./we-run-this.sh
@@ -37,7 +37,7 @@ jobs:
3737
cat ./we-run-this.sh
3838
echo "*******************************************"
3939
bash -x ./we-run-this.sh
40-
40+
4141
echo "tests complete"
4242
echo "*******************************************"
4343
echo "::endgroup::"

0 commit comments

Comments
 (0)