Skip to content

Commit 38d67db

Browse files
larryliu0820facebook-github-bot
authored andcommitted
Link MPS and CoreML delegate library into portable_lib (#4040)
Summary: As titled. MPS and CoreML should be linked into portable_lib on mac. Pull Request resolved: #4040 Test Plan: See CI job works? Reviewed By: dbort Differential Revision: D59351891 Pulled By: larryliu0820 fbshipit-source-id: 2d551b84b1fd09995ef3cbf0594b2e1b46854276
1 parent 516f7f0 commit 38d67db

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

README-wheel.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ restrictions:
1717
* Only the [XNNPACK backend
1818
delegate](https://pytorch.org/executorch/main/native-delegates-executorch-xnnpack-delegate.html)
1919
is linked into the prebuilt module
20+
* [macOS only] [Core ML](https://pytorch.org/executorch/main/build-run-coreml.html) and [MPS](https://pytorch.org/executorch/main/build-run-mps.html) backend delegates are linked into the prebuilt module.
2021

2122
Please visit the [ExecuTorch website](https://pytorch.org/executorch/) for
2223
tutorials and documentation. Here are some starting points:

build/packaging/env_var_script_m1.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,5 @@ export CMAKE_ARGS="${CMAKE_ARGS:-}"
2020
CMAKE_ARGS="${CMAKE_ARGS} -DEXECUTORCH_BUILD_XNNPACK=ON"
2121

2222
# When building for macOS, link additional backends into the pybindings runtime.
23-
24-
# TODO(dbort): Make these build properly in the CI environment.
25-
# CMAKE_ARGS="${CMAKE_ARGS} -DEXECUTORCH_BUILD_COREML=ON"
26-
# CMAKE_ARGS="${CMAKE_ARGS} -DEXECUTORCH_BUILD_MPS=ON"
23+
CMAKE_ARGS="${CMAKE_ARGS} -DEXECUTORCH_BUILD_COREML=ON"
24+
CMAKE_ARGS="${CMAKE_ARGS} -DEXECUTORCH_BUILD_MPS=ON"

0 commit comments

Comments
 (0)