Skip to content

Commit 3a5be6b

Browse files
Gasoonjiafacebook-github-bot
authored andcommitted
remove duplicate generate_lib_aten target under aten kernel
Summary: generate_lib and generate_lib_aten are exactly the same under executorch/kernels/aten. Remove the generate_lib_aten for better understanding. Differential Revision: D55937122
1 parent c4ac14c commit 3a5be6b

File tree

3 files changed

+2
-17
lines changed

3 files changed

+2
-17
lines changed

examples/models/llama2/runner/targets.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
22

33
def _get_operator_lib(aten = False):
44
if aten:
5-
return ["//executorch/kernels/aten:generated_lib_aten"]
5+
return ["//executorch/kernels/aten:generated_lib"]
66
elif runtime.is_oss:
77
return ["//executorch/kernels/portable:generated_lib", "//executorch/examples/models/llama2/custom_ops:custom_ops"]
88
else:

kernels/aten/targets.bzl

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,3 @@ def define_common_targets():
3535
"@EXECUTORCH_CLIENTS",
3636
],
3737
)
38-
39-
# TODO(T149415783): temporarily testing portable kernel "in aten mode" and remove after migration is done
40-
executorch_generated_lib(
41-
name = "generated_lib_aten",
42-
aten_mode = True,
43-
deps = [
44-
":executorch_aten_ops",
45-
],
46-
functions_yaml_target = None,
47-
define_static_targets = True,
48-
visibility = [
49-
"//executorch/...",
50-
"@EXECUTORCH_CLIENTS",
51-
],
52-
)

shim/xplat/executorch/extension/pybindings/pybindings.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ ATEN_MODULE_DEPS = [
3737
# Generated lib for all ATen ops with aten kernel used by models in model inventory
3838
MODELS_ATEN_OPS_ATEN_MODE_GENERATED_LIB = [
3939
"//executorch/kernels/quantized:generated_lib_aten",
40-
"//executorch/kernels/aten:generated_lib_aten",
40+
"//executorch/kernels/aten:generated_lib",
4141
]
4242

4343
def executorch_pybindings(python_module_name, srcs = [], cppdeps = [], visibility = ["//executorch/..."], types = [], compiler_flags = []):

0 commit comments

Comments
 (0)