Skip to content

Commit 41bf83a

Browse files
committed
[ET-VK] Renaming slice_channel and slice_batch_height_width files to reflect change in its utility.
Pull Request resolved: #9137 This diff renames files `slice_batch_height_width.y*` to `slice_unpacked_dim.*` and `slice_channel.*` to `slice_packed_dim.*` to reflect the change in their utility after enabling all dim packing for slice op. ghstack-source-id: 271070838 @exported-using-ghexport Differential Revision: [D70919994](https://our.internmc.facebook.com/intern/diff/D70919994/)
1 parent e8faa23 commit 41bf83a

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
slice_channel:
1+
slice_packed_dim:
22
parameter_names_with_default_values:
33
DTYPE: float
44
NDIM: 3
@@ -8,4 +8,4 @@ slice_channel:
88
- VALUE: half
99
- VALUE: float
1010
shader_variants:
11-
- NAME: slice_channel
11+
- NAME: slice_packed_dim
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
slice_batch_height_width:
1+
slice_unpacked_dim:
22
parameter_names_with_default_values:
33
DTYPE: float
44
NDIM: 3
@@ -7,4 +7,4 @@ slice_batch_height_width:
77
- VALUE: half
88
- VALUE: float
99
shader_variants:
10-
- NAME: slice_batch_height_width
10+
- NAME: slice_unpacked_dim

backends/vulkan/runtime/graph/ops/impl/Slice.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ void add_slice_tensor_copy_node(
8383
// if slice dim is the same as the packed dim, we can use the channel slice
8484
if (dim_index == packed_dim_idx) {
8585
// slice by channel
86-
std::string kernel_name = "slice_channel";
86+
std::string kernel_name = "slice_packed_dim";
8787
kernel_name.reserve(kShaderNameReserve);
8888
add_dtype_suffix(kernel_name, *t_out);
8989

@@ -119,7 +119,7 @@ void add_slice_tensor_copy_node(
119119
in_channel_stride = utils::div_up_4(in_channel_stride);
120120
}
121121

122-
std::string kernel_name = "slice_batch_height_width";
122+
std::string kernel_name = "slice_unpacked_dim";
123123
kernel_name.reserve(kShaderNameReserve);
124124
add_dtype_suffix(kernel_name, *t_out);
125125

0 commit comments

Comments
 (0)