Throw in VK_GET_OP_FN if op is not found (#3028)

jorgep31415 · facebook-github-bot · commit 4d7dd036a833 · 2024-04-12T17:34:30.000-07:00
Summary: Pull Request resolved: #3028 Make yipjustin happy. Forgot this safeguard when I originally wrote the `OperatorRegistry` class. Reviewed By: SS-JIA Differential Revision: D56085588 fbshipit-source-id: ba116eab8054e3610011fd0c8ffc0aabe61ae8ea
diff --git a/backends/vulkan/runtime/graph/ops/OperatorRegistry.cpp b/backends/vulkan/runtime/graph/ops/OperatorRegistry.cpp
@@ -16,7 +16,9 @@ bool OperatorRegistry::has_op(const std::string& name) {
 
 OperatorRegistry::OpFunction& OperatorRegistry::get_op_fn(
     const std::string& name) {
-  return table_.find(name)->second;
+  const auto it = table_.find(name);
+  VK_CHECK_COND(it != table_.end(), "Could not find operator with name ", name);
+  return it->second;
 }
 
 void OperatorRegistry::register_op(const std::string& name, OpFunction& fn) {

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,9 @@ bool OperatorRegistry::has_op(const std::string& name) {`
`16`	`16`
`17`	`17`	`OperatorRegistry::OpFunction& OperatorRegistry::get_op_fn(`
`18`	`18`	`const std::string& name) {`
`19`		`- return table_.find(name)->second;`
	`19`	`+ const auto it = table_.find(name);`
	`20`	`+ VK_CHECK_COND(it != table_.end(), "Could not find operator with name ", name);`
	`21`	`+ return it->second;`
`20`	`22`	`}`
`21`	`23`
`22`	`24`	`void OperatorRegistry::register_op(const std::string& name, OpFunction& fn) {`