Skip to content

Commit 52afdb2

Browse files
committed
DO NOT LAND: Disable wheel delocation on macos
DO NOT LAND: Update this to point to the real infra repo once the `delocate-wheel` input is available there. The executorch build system will ensure that .dylib/.so files have LC_LOAD_DYLIB and LC_RPATH entries that will work when they're installed. Delocating (i.e., making copies of the .dylibs that ET's libs depend on) will break any libs that depend on the torch libraries if users ever import both `torch` and the executorch library. Both import paths must load exactly the same file, not just a copy of it.
1 parent 976d61e commit 52afdb2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/build-wheels-m1.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
smoke-test-script: build/packaging/smoke_test.py
4545
package-name: executorch
4646
name: ${{ matrix.repository }}
47-
uses: pytorch/test-infra/.github/workflows/build_wheels_macos.yml@release/2.3
47+
uses: dbort/pytorch-test-infra/.github/workflows/build_wheels_macos.yml@dbort/optional-delocate-wheel-release
4848
with:
4949
repository: ${{ matrix.repository }}
5050
ref: ""
@@ -55,6 +55,7 @@ jobs:
5555
# "recursive" default to do less work, and to give the buck daemon fewer
5656
# files to look at.
5757
submodules: true
58+
delocate-wheel: false
5859
env-var-script: build/packaging/env_var_script_m1.sh
5960
pre-script: ${{ matrix.pre-script }}
6061
post-script: ${{ matrix.post-script }}

0 commit comments

Comments
 (0)