executorch-the-CMake-target should re-export executorch_core, shouldn't it? (#8404)

swolchok · web-flow · commit 5dd2ed35d750 · 2025-02-12T08:02:24.000-08:00
This seems to fix QNN build failures, and it doesn't make sense to me that every executorch (the CMake target) consumer should also have to explicitly link executorch_core
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -596,7 +596,7 @@ endif()
 # any backends.
 #
 add_library(executorch ${_executorch__srcs})
-target_link_libraries(executorch PRIVATE executorch_core)
+target_link_libraries(executorch PUBLIC executorch_core)
 target_include_directories(executorch PUBLIC ${_common_include_directories})
 target_compile_definitions(executorch PUBLIC C10_USING_CUSTOM_GENERATED_MACROS)
 target_compile_options(executorch PUBLIC ${_common_compile_options})

Original file line number	Diff line number	Diff line change
`@@ -596,7 +596,7 @@ endif()`
`596`	`596`	`# any backends.`
`597`	`597`	`#`
`598`	`598`	`add_library(executorch ${_executorch__srcs})`
`599`		`-target_link_libraries(executorch PRIVATE executorch_core)`
	`599`	`+target_link_libraries(executorch PUBLIC executorch_core)`
`600`	`600`	`target_include_directories(executorch PUBLIC ${_common_include_directories})`
`601`	`601`	`target_compile_definitions(executorch PUBLIC C10_USING_CUSTOM_GENERATED_MACROS)`
`602`	`602`	`target_compile_options(executorch PUBLIC ${_common_compile_options})`