Skip to content

Commit 6528cb9

Browse files
tarun292facebook-github-bot
authored andcommitted
Use xplat/caffe2:ovrsource_aten_Config.h for arvr build modes (#9462)
Summary: Pull Request resolved: #9462 For arvr modes we should use `//xplat/caffe2:ovrsource_aten_Config.h` to get the ATen config headers as the `ovrsource` variants are what's used in arvr repos and using ``"//xplat/caffe2:ovrsource_aten_Config.h"` causes the ovrsource ones to get overwritten and hence results in build failures. Reviewed By: thejarlid Differential Revision: D71506180
1 parent 1a9a59b commit 6528cb9

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

runtime/core/portable_type/c10/c10/targets.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
2+
load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_arvr_mode")
23

34
def get_sleef_preprocessor_flags():
45
if runtime.is_oss:
@@ -78,9 +79,8 @@ def define_common_targets():
7879
] + get_sleef_preprocessor_flags(),
7980
xplat_exported_deps = [
8081
"//xplat/caffe2:aten_header",
81-
"//xplat/caffe2:generated_aten_config_header",
8282
"//xplat/caffe2/c10:c10_headers",
83-
],
83+
] + ["//xplat/caffe2:ovrsource_aten_Config.h" if is_arvr_mode() else "//xplat/caffe2:generated_aten_config_header",],
8484
exported_preprocessor_flags = select({
8585
# Intentionally punting on non-fbcode x86 sleef support
8686
# for now because of fbsource//third-party/sleef:sleef

shim_et/tools

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
def is_arvr_mode():
2+
return False

0 commit comments

Comments
 (0)