Skip to content

Commit 682d9ac

Browse files
shoumikhinfacebook-github-bot
authored andcommitted
Turn off optimized kernels so that they don't build and link unless needed. (#2676)
Summary: Pull Request resolved: #2676 Reviewed By: tarun292 Differential Revision: D55348713 fbshipit-source-id: 2a7ce1dce2d18d43703b9b0b3c40d5abd19bff60
1 parent bddeb99 commit 682d9ac

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.ci/scripts/test_llama.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ cmake_install_executorch_libraries() {
4747
-DCMAKE_BUILD_TYPE=Release \
4848
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
4949
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
50+
-DEXECUTORCH_REGISTER_OPTIMIZED_OPS=ON \
5051
-DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
5152
-Bcmake-out .
5253
cmake --build cmake-out -j9 --target install --config Release
@@ -58,6 +59,7 @@ cmake_build_llama_runner() {
5859
retry cmake -DBUCK2="$BUCK" \
5960
-DCMAKE_INSTALL_PREFIX=cmake-out \
6061
-DCMAKE_BUILD_TYPE=Release \
62+
-DEXECUTORCH_REGISTER_OPTIMIZED_OPS=ON \
6163
-DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
6264
-Bcmake-out/${dir} \
6365
${dir}

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ option(EXECUTORCH_BUILD_PYBIND "Build the Python Bindings" OFF)
158158

159159
option(EXECUTORCH_BUILD_QNN "Build the Qualcomm backend" OFF)
160160

161-
option(EXECUTORCH_REGISTER_OPTIMIZED_OPS "Build the optimized kernels" ON)
161+
option(EXECUTORCH_REGISTER_OPTIMIZED_OPS "Build the optimized kernels" OFF)
162162

163163
option(EXECUTORCH_REGISTER_QUANTIZED_OPS "Build the quantized kernels" OFF)
164164

examples/models/llama2/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
cmake_minimum_required(VERSION 3.19)
1919
project(llama_runner)
2020

21-
option(EXECUTORCH_REGISTER_OPTIMIZED_OPS "Build the optimized kernels" ON)
21+
option(EXECUTORCH_REGISTER_OPTIMIZED_OPS "Build the optimized kernels" OFF)
2222

2323
if(NOT PYTHON_EXECUTABLE)
2424
set(PYTHON_EXECUTABLE python3)

0 commit comments

Comments
 (0)