Skip to content

Commit 718aa6f

Browse files
authored
Reduce macOS CI jobs and add more Arm64 jobs. (#9228)
Depends on #9227 and #9207 Here's the net result after a sequence of PRs: - Reduce trunk test-model-macos jobs (from 38 down to 15) - Add arm64 trunk test-model jobs (from 0 up to 31) - Add arm64 pull test-model-jobs jobs (+4)
1 parent 27bacff commit 718aa6f

File tree

2 files changed

+26
-13
lines changed

2 files changed

+26
-13
lines changed

.github/workflows/pull.yml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,23 @@ jobs:
4949
model: [mv3, vit]
5050
backend: [portable, xnnpack-quantization-delegation]
5151
build-tool: [cmake, buck2]
52-
runner: [linux.2xlarge]
52+
runner: [linux.2xlarge, linux.arm64.2xlarge]
53+
docker-image: [executorch-ubuntu-22.04-clang12, executorch-ubuntu-22.04-gcc11-aarch64]
54+
# Excluding specific runner + docker image combinations that don't make sense:
55+
# - Excluding the ARM64 gcc image on the x86 runner (linux.2xlarge)
56+
# - Excluding the x86 clang image on the ARM64 runner (linux.arm64.2xlarge)
57+
exclude:
58+
- runner: linux.2xlarge
59+
docker-image: executorch-ubuntu-22.04-gcc11-aarch64
60+
- runner: linux.arm64.2xlarge
61+
docker-image: executorch-ubuntu-22.04-clang12
62+
# TODO: Need to figure out why buck2 doesnt work on Graviton instances.
63+
- runner: linux.arm64.2xlarge
64+
build-tool: buck2
5365
fail-fast: false
5466
with:
5567
runner: ${{ matrix.runner }}
56-
docker-image: executorch-ubuntu-22.04-clang12
68+
docker-image: ${{ matrix.docker-image }}
5769
submodules: 'true'
5870
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
5971
timeout: 90

.github/workflows/trunk.yml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,25 +23,21 @@ jobs:
2323
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
2424
strategy:
2525
matrix:
26-
model: [add, add_mul, emformer_join, emformer_transcribe, ic3, ic4, linear, llama2, mobilebert, mv2, mv3, resnet18, resnet50, vit, w2l]
27-
backend: [portable, xnnpack-quantization-delegation]
26+
model: [emformer_join, ic4, llama2, mobilebert, mv3, resnet50, vit, w2l]
27+
backend: [xnnpack-quantization-delegation]
2828
include:
2929
- model: efficient_sam
3030
backend: portable
3131
- model: llama
3232
backend: portable
3333
- model: llama3_2_vision_encoder
3434
backend: portable
35-
- model: lstm
36-
backend: portable
37-
- model: mul
35+
- model: mv3
3836
backend: portable
3937
- model: phi-4-mini
4038
backend: portable
4139
- model: qwen2_5
4240
backend: portable
43-
- model: softmax
44-
backend: portable
4541
fail-fast: false
4642
with:
4743
runner: macos-m1-stable
@@ -53,13 +49,12 @@ jobs:
5349
MODEL_NAME=${{ matrix.model }}
5450
BUILD_TOOL=cmake
5551
BACKEND=${{ matrix.backend }}
56-
DEMO_BACKEND_DELEGATION=${{ matrix.demo_backend_delegation }}
5752
5853
bash .ci/scripts/setup-conda.sh
5954
# Setup MacOS dependencies as there is no Docker support on MacOS atm
6055
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh --build-tool "${BUILD_TOOL}"
6156
# Build and test executorch
62-
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/test_model.sh "${MODEL_NAME}" "${BUILD_TOOL}" "${BACKEND}" "${DEMO_BACKEND_DELEGATION}"
57+
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/test_model.sh "${MODEL_NAME}" "${BUILD_TOOL}" "${BACKEND}"
6358
6459
test-models-linux-aarch64:
6560
name: test-models-linux-aarch64
@@ -71,10 +66,16 @@ jobs:
7166
matrix:
7267
model: [linear, add, add_mul, ic3, ic4, mv2, mv3, resnet18, resnet50, vit, w2l, mobilebert, emformer_join, emformer_transcribe]
7368
backend: [portable, xnnpack-quantization-delegation]
74-
runner: [linux.arm64.2xlarge]
69+
include:
70+
- model: lstm
71+
backend: portable
72+
- model: mul
73+
backend: portable
74+
- model: softmax
75+
backend: portable
7576
fail-fast: false
7677
with:
77-
runner: ${{ matrix.runner }}
78+
runner: linux.arm64.2xlarge
7879
docker-image: executorch-ubuntu-22.04-gcc11-aarch64
7980
submodules: 'true'
8081
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}

0 commit comments

Comments
 (0)