Skip to content

Commit 73f50df

Browse files
pytorchbotSS-JIA
andauthored
[ET-VK][ez] Fix 8-bit linear shaders extension requirement (#7607)
## Context 8-bit linear compute shaders only require the 8bit_storage extension for buffer tensors. Now that we are checking that the GPU supports required extensions, we need to be more careful about declaring that a extensions as required. Differential Revision: [D68035429](https://our.internmc.facebook.com/intern/diff/D68035429/) ghstack-source-id: 260953913 Pull Request resolved: #7600 Co-authored-by: Stephen Jia <[email protected]>
1 parent 9666ee8 commit 73f50df

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

backends/vulkan/runtime/graph/ops/glsl/q_8w_linear.glsl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
${define_active_storage_type(STORAGE)}
1717

1818
${define_required_extensions(DTYPE)}
19-
${define_required_extensions("int8")}
19+
$if STORAGE == "buffer":
20+
${define_required_extensions("int8")}
2021

2122
#include "indexing_utils.h"
2223

backends/vulkan/runtime/graph/ops/glsl/q_8w_linear_optimized.glsl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
${define_active_storage_type(STORAGE)}
1717

1818
${define_required_extensions(DTYPE)}
19-
${define_required_extensions("int8")}
19+
$if STORAGE == "buffer":
20+
${define_required_extensions("int8")}
2021

2122

2223
$if BATCH_MODE:

0 commit comments

Comments
 (0)