Update on "[ET-VK] Introduce DynamicDispatchNode"

## Context

The `DynamicDispatchNode` class in introduced in this diff to allow for shader re-selection upon input resize. See the previous diff in the stack for more context on why this functionality is needed.

Differential Revision: [D75013780](https://our.internmc.facebook.com/intern/diff/D75013780/)

[ghstack-poisoned]

Author: SS-JIA

backends/vulkan/runtime/graph/ops/DispatchNode.cpp

@@ -12,8 +12,6 @@
 
 #include <executorch/backends/vulkan/runtime/graph/ops/utils/BindingUtils.h>
 
-#include <iostream>
-
 namespace vkcompute {
 
 DispatchNode::DispatchNode(
@@ -41,8 +39,6 @@ void DispatchNode::encode(ComputeGraph* graph) {
   if (!shader_) {
     return;
   }
-  std::cout << "dynamically dispatching... " << shader_.kernel_name
-            << std::endl;
   api::Context* const context = graph->context();
   vkapi::PipelineBarrier pipeline_barrier{};
 

backends/vulkan/runtime/graph/ops/DynamicDispatchNode.cpp

@@ -34,10 +34,10 @@ DynamicDispatchNode::DynamicDispatchNode(
           pick_local_wg_fn(&graph, args, resize_args),
           args,
           params,
+          push_constants,
           spec_vars,
-          resize_fn,
           resize_args,
-          push_constants),
+          resize_fn),
       pick_shader_fn_(pick_shader_fn),
       pick_global_wg_fn_(pick_global_wg_fn),
       pick_local_wg_fn_(pick_local_wg_fn) {}

backends/vulkan/runtime/graph/ops/DynamicDispatchNode.h

@@ -29,15 +29,15 @@ class DynamicDispatchNode final : public DispatchNode {
   using PickShaderFn = const std::function<vkapi::ShaderInfo(
       ComputeGraph*,
       const std::vector<ArgGroup>&,
-      const std::vector<ValueRef>)>;
+      const std::vector<ValueRef>&)>;
   using PickGlobalFn = const std::function<utils::uvec3(
       ComputeGraph*,
       const std::vector<ArgGroup>&,
-      const std::vector<ValueRef>)>;
+      const std::vector<ValueRef>&)>;
   using PickLocalFn = const std::function<utils::uvec3(
       ComputeGraph*,
       const std::vector<ArgGroup>&,
-      const std::vector<ValueRef>)>;
+      const std::vector<ValueRef>&)>;
 
   explicit DynamicDispatchNode(
       ComputeGraph& graph,

backends/vulkan/test/vulkan_compute_api_test.cpp

@@ -3301,7 +3301,7 @@ TEST(VulkanComputeGraphOpsTest, test_to_copy) {
 vkapi::ShaderInfo pick_dynamic_dispatch_shader(
     ComputeGraph* graph,
     const std::vector<ArgGroup>& args,
-    const std::vector<ValueRef> additional_args) {
+    const std::vector<ValueRef>& additional_args) {
   const ValueRef mat1 = args[1].refs[0];
 
   std::string kernel_name = "dynamic_dispatch_test";
@@ -3316,7 +3316,7 @@ vkapi::ShaderInfo pick_dynamic_dispatch_shader(
 utils::uvec3 pick_dynamic_dispatch_global_wg_size(
     ComputeGraph* graph,
     const std::vector<ArgGroup>& args,
-    const std::vector<ValueRef> additional_args) {
+    const std::vector<ValueRef>& additional_args) {
   const ValueRef out = args[0].refs[0];
 
   return graph->logical_limits_of(out);
@@ -3325,14 +3325,14 @@ utils::uvec3 pick_dynamic_dispatch_global_wg_size(
 utils::uvec3 pick_dynamic_dispatch_local_wg_size(
     ComputeGraph* graph,
     const std::vector<ArgGroup>& args,
-    const std::vector<ValueRef> additional_args) {
+    const std::vector<ValueRef>& additional_args) {
   return {64, 1, 1};
 }
 
 void resize_dynamic_dispatch_node(
     ComputeGraph* graph,
     const std::vector<ArgGroup>& args,
-    const std::vector<ValueRef> additional_args) {
+    const std::vector<ValueRef>& additional_args) {
   const ValueRef out = args[0].refs[0];
   const ValueRef mat1 = args[1].refs[0];