Build custom ops in pybinding

larryliu0820 · larryliu0820 · commit 7ceebe7f2dbd · 2024-04-23T17:32:11.000-07:00
Right now we are not building it and it is causing missing ops in
torchchat.

This PR adds it into pybinding.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -559,6 +559,7 @@ if(EXECUTORCH_BUILD_PYBIND)
   endif()
 
   if(EXECUTORCH_BUILD_CUSTOM)
+    target_link_options_shared_lib(custom_ops)
     list(APPEND _dep_libs custom_ops)
   endif()
 
diff --git a/setup.py b/setup.py
@@ -389,6 +389,7 @@ def run(self):
 
         if ShouldBuild.llama_custom_ops:
             cmake_args += [
+                "-DEXECUTORCH_BUILD_CUSTOM=ON",  # add llama sdpa ops to pybindings.
                 "-DEXECUTORCH_BUILD_CUSTOM_OPS_AOT=ON",
             ]
             build_args += ["--target", "custom_ops_aot_lib"]

Original file line number	Diff line number	Diff line change
`@@ -389,6 +389,7 @@ def run(self):`
`389`	`389`
`390`	`390`	`if ShouldBuild.llama_custom_ops:`
`391`	`391`	`cmake_args += [`
	`392`	`+ "-DEXECUTORCH_BUILD_CUSTOM=ON", # add llama sdpa ops to pybindings.`
`392`	`393`	`"-DEXECUTORCH_BUILD_CUSTOM_OPS_AOT=ON",`
`393`	`394`	`]`
`394`	`395`	`build_args += ["--target", "custom_ops_aot_lib"]`