Fix debugger tests - sdk issue (#2503)

Summary:
For sdk < 17.4 there is no profiling support and we were returning `nil` from `ETCoreMLModelAnalyzer` if the profiler was nil. We could still support model debugging even if we can't profile the model, the change addresses it by creating the `ETCoreMLModelAnalyzer` instance.

Pull Request resolved: #2503

Reviewed By: shoumikhin

Differential Revision: D55076647

Pulled By: tarun292

fbshipit-source-id: 28f96042e5f89aef7bd6ffc8ada52191594c69f2

Author: cymbalrush

backends/apple/coreml/runtime/delegate/ETCoreMLLogging.h

@@ -22,6 +22,7 @@ typedef NS_ERROR_ENUM(ETCoreMLErrorDomain, ETCoreMLError) {
     ETCoreMLErrorBrokenModel, // CoreML model doesn't match the input and output specification.
     ETCoreMLErrorCompilationFailed, // CoreML model failed to compile.
     ETCoreMLErrorModelCompilationNotSupported, // CoreML model compilation is not supported by the target.
+    ETCoreMLErrorModelProfilingNotSupported, // Model profiling is not supported by the target.
     ETCoreMLErrorModelSaveFailed, // Failed to save CoreML model to disk.
     ETCoreMLErrorModelCacheCreationFailed, // Failed to create model cache.
     ETCoreMLErrorInternalError, // Internal error.

backends/apple/coreml/runtime/sdk/ETCoreMLModelAnalyzer.mm

@@ -99,33 +99,34 @@ - (nullable instancetype)initWithCompiledModelAsset:(ETCoreMLAsset *)compiledMod
         return nil;
     }
 
+    NSError *localError = nil;
     ETCoreMLModel *model = [ETCoreMLModelLoader loadModelWithContentsOfURL:compiledModelAsset.contentURL
                                                              configuration:configuration
                                                                   metadata:metadata
                                                               assetManager:assetManager
-                                                                     error:error];
+                                                                     error:&localError];
     if (!model) {
-        return nil;
+        ETCoreMLLogError(localError,
+                         "%@: Failed to create model profiler.",
+                         NSStringFromClass(ETCoreMLAssetManager.class));
     }
 
-    NSError *localError = nil;
+    localError = nil;
     NSDictionary<ETCoreMLModelStructurePath *, NSString *> *pathToSymbolNameMap = get_path_to_symbol_name_map(modelAsset,
                                                                                                               assetManager.fileManager,
                                                                                                               &localError);
 
     if (localError) {
-        os_log_error(ETCoreMLErrorUtils.loggingChannel , "%@: The model package at path=%@ has invalid or missing debug symbols file.",
-                     NSStringFromClass(ETCoreMLModelAnalyzer.class),
-                     modelAsset.contentURL.path);
+        ETCoreMLLogError(localError,
+                         "%@: The model package at path=%@ has invalid or missing debug symbols file.",
+                         NSStringFromClass(ETCoreMLModelAnalyzer.class),
+                         modelAsset.contentURL.path);
     }
 
     ETCoreMLModelProfiler *profiler = [[ETCoreMLModelProfiler alloc] initWithCompiledModelAsset:model.asset
                                                                                     outputNames:model.orderedOutputNames
                                                                                   configuration:configuration
                                                                                           error:error];
-    if (!profiler) {
-        return nil;
-    }
 
     self = [super init];
     if (self) {
@@ -145,6 +146,13 @@ - (nullable instancetype)initWithCompiledModelAsset:(ETCoreMLAsset *)compiledMod
                                            predictionOptions:(MLPredictionOptions *)predictionOptions
                                                  eventLogger:(const executorchcoreml::ModelEventLogger *)eventLogger
                                                        error:(NSError * __autoreleasing *)error {
+    if (self.profiler == nil) {
+        ETCoreMLLogErrorAndSetNSError(error,
+                                      ETCoreMLErrorModelProfilingNotSupported,
+                                      "%@: Model profiling is only available for macOS >= 14.4, iOS >= 17.4, tvOS >= 17.4 and watchOS >= 10.4.",
+                                      NSStringFromClass(ETCoreMLModelAnalyzer.class));
+        return nil;
+    }
     NSArray<MLMultiArray *> *modelOutputs = nil;
     NSArray<ETCoreMLModelStructurePath *> *operationPaths = self.profiler.operationPaths;
     ETCoreMLModelProfilingResult *profilingInfos = [self.profiler profilingInfoForOperationsAtPaths:operationPaths

backends/apple/coreml/runtime/sdk/ETCoreMLModelProfiler.mm

@@ -292,7 +292,7 @@ - (nullable instancetype)initWithCompiledModelAsset:(ETCoreMLAsset *)compiledMod
     }
 #endif
     ETCoreMLLogErrorAndSetNSError(error,
-                                  ETCoreMLErrorCorruptedModel,
+                                  ETCoreMLErrorModelProfilingNotSupported,
                                   "%@: Model profiling is only available for macOS >= 14.4, iOS >= 17.4, tvOS >= 17.4 and watchOS >= 10.4.",
                                   NSStringFromClass(self.class));
     return nil;