Skip to content

Commit 838e770

Browse files
committed
Update on "[ET-VK][12/n] aten.cat with more codegen"
1. The `aten.cat` operation are very straightforward using the `copy_*_node`. 2. Complexity comes from the code-gen. We need to introduce a `AT_TENSOR_LIST` type, which contains a list of `AT_TENSOR` with `is_in=True`. The tensor list itself as a container is not an `IOValueRef`, but the element inside are. It leads to some ugly if-then-else in the codegen. Differential Revision: [D56626865](https://our.internmc.facebook.com/intern/diff/D56626865/) [ghstack-poisoned]
1 parent 7a46ac7 commit 838e770

File tree

1 file changed

+0
-6
lines changed
  • backends/vulkan/runtime/graph/ops/impl

1 file changed

+0
-6
lines changed

backends/vulkan/runtime/graph/ops/impl/Cat.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,6 @@ void add_cat_default_node(
3333
int64_t dim = graph.extract_scalar<int64_t>(dim_ref);
3434
vTensorPtr t_out = graph.get_tensor(out);
3535

36-
/*
37-
for (ValueRef input_ref : *input_list) {
38-
vTensorPtr t_in = graph.get_tensor(input_ref);
39-
}
40-
*/
41-
4236
NchwDim nchw_dim = normalize_to_nchw_dim(*t_out, dim);
4337

4438
// TODO: Find ways to factor out the similar code for width, height, and batch

0 commit comments

Comments
 (0)