Update on "[10/n][ET-VK] Introduce create_image_from_ahb utility"

We now include handle to `VkDevice` in `VulkanImage` since our allocations don't go through VMA.

Differential Revision: [D63298759](https://our.internmc.facebook.com/intern/diff/D63298759/)

[ghstack-poisoned]

Author: jorgep31415

backends/vulkan/runtime/vk_api/memory/Allocator.cpp

@@ -134,8 +134,8 @@ VulkanImage Allocator::create_image(
       image_props,
       view_props,
       sampler_props,
-      initial_layout,
       sampler,
+      initial_layout,
       allocate_memory);
 }
 

backends/vulkan/runtime/vk_api/memory/Image.cpp

@@ -115,8 +115,8 @@ VulkanImage::VulkanImage(
     const ImageProperties& image_props,
     const ViewProperties& view_props,
     const SamplerProperties& sampler_props,
-    const VkImageLayout layout,
     VkSampler sampler,
+    const VkImageLayout layout,
     const bool allocate_memory)
     : device_{device},
       image_properties_(image_props),
@@ -186,7 +186,8 @@ VulkanImage::VulkanImage(
     const ImageProperties& image_props,
     VkImage image,
     VkImageView image_view,
-    VkSampler sampler)
+    VkSampler sampler,
+    const VkImageLayout layout)
     : device_{device},
       image_properties_{image_props},
       view_properties_{},
@@ -200,7 +201,7 @@ VulkanImage::VulkanImage(
           image_view,
           sampler,
       },
-      layout_{VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL} {}
+      layout_{layout} {}
 
 VulkanImage::VulkanImage(const VulkanImage& other) noexcept
     : device_(other.device_),

backends/vulkan/runtime/vk_api/memory/Image.h

@@ -99,16 +99,17 @@ class VulkanImage final {
       const ImageProperties&,
       const ViewProperties&,
       const SamplerProperties&,
-      const VkImageLayout layout,
       VkSampler,
+      const VkImageLayout,
       const bool allocate_memory = true);
 
   explicit VulkanImage(
       VkDevice,
       const ImageProperties&,
       VkImage,
       VkImageView,
-      VkSampler);
+      VkSampler,
+      const VkImageLayout);
 
  protected:
   /*