Skip to content

Commit 8a738bc

Browse files
larryliu0820facebook-github-bot
authored andcommitted
Fix bugs in selective build cmake (#182)
Summary: Pull Request resolved: #182 There's an issue passing op names into selective build. This diff fixes it. Reviewed By: guangy10 Differential Revision: D48834420 fbshipit-source-id: a6009b24bb7fd928e5d06fd0d4e7023c7ef21111
1 parent 11feabf commit 8a738bc

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

examples/selective_build/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ include(${EXECUTORCH_ROOT}/build/Codegen.cmake)
2828
#
2929
set(_kernel_lib)
3030
if(SELECT_ALL_OPS)
31-
gen_selected_ops("" "" ${SELECT_ALL_OPS})
31+
gen_selected_ops("" "" "${SELECT_ALL_OPS}")
3232
list(APPEND _kernel_lib portable_kernels)
3333
elseif(SELECT_OPS_LIST)
34-
gen_selected_ops("" ${SELECT_OPS_LIST} "")
34+
gen_selected_ops("" "${SELECT_OPS_LIST}" "")
3535
list(APPEND _kernel_lib portable_kernels)
3636
elseif(SELECT_OPS_YAML)
3737
set(_custom_ops_yaml ${EXECUTORCH_ROOT}/examples/custom_ops/custom_ops.yaml)
38-
gen_selected_ops(${_custom_ops_yaml} "" "")
38+
gen_selected_ops("${_custom_ops_yaml}" "" "")
3939
set(kernel_sources
4040
${EXECUTORCH_ROOT}/examples/custom_ops/custom_ops_1_out.cpp
4141
${EXECUTORCH_ROOT}/examples/custom_ops/custom_ops_2_out.cpp)

examples/selective_build/test_selective_build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ test_cmake_select_ops_in_list() {
7979
&& cd cmake-out \
8080
&& cmake -DBUCK2=buck2 \
8181
-DBUILD_SELECTIVE_BUILD_TEST=ON \
82-
-DSELECT_OPS_LIST="aten::add.out;aten::mm.out" \
82+
-DSELECT_OPS_LIST="aten::add.out,aten::mm.out" \
8383
-DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" ..)
8484

8585
echo "Build selective build test"

0 commit comments

Comments
 (0)