Skip to content

Commit 8c68a62

Browse files
committed
lint
1 parent e94831e commit 8c68a62

File tree

3 files changed

+14
-16
lines changed

3 files changed

+14
-16
lines changed

exir/emit/_emitter.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -946,9 +946,7 @@ def _emit_view(self, args: Tuple[_Argument, ...]) -> _EmitterValue:
946946
# Elide the view if it is static and memory planned
947947
spec = self.node.meta["spec"]
948948
is_static = spec.is_static_shape_tensor
949-
is_memory_planned = (spec.mem_id is not None) and (
950-
spec.mem_offset is not None
951-
)
949+
is_memory_planned = (spec.mem_id is not None) and (spec.mem_offset is not None)
952950
is_memory_planned = is_memory_planned or (
953951
spec.const and spec.storage is not None
954952
)

exir/emit/test/test_emit.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -339,20 +339,17 @@ def expected_view_ops(config):
339339
else:
340340
return ["aten::view_copy"]
341341

342-
343342
for opname in removed_ops:
344343
self.assertEqual(
345344
self.count_node(edge.exported_program().graph_module, opname), 0
346345
)
347346
for opname in expected_ops:
348-
self.assertTrue(
349-
self.count_node(edge.exported_program().graph_module, opname) >= 1
350-
)
347+
self.assertTrue(
348+
self.count_node(edge.exported_program().graph_module, opname) >= 1
349+
)
351350

352351
for remove_view_copy in [True, False]:
353-
config = exir.ExecutorchBackendConfig(
354-
remove_view_copy=remove_view_copy
355-
)
352+
config = exir.ExecutorchBackendConfig(remove_view_copy=remove_view_copy)
356353
edge_copy = deepcopy(edge)
357354
program = edge_copy.to_executorch(config=config).executorch_program
358355
for opname in removed_ops:
@@ -363,7 +360,10 @@ def expected_view_ops(config):
363360
self.assertTrue(
364361
any(op.name == opname for op in program.execution_plan[0].operators)
365362
)
366-
self.assertTrue(len(program.execution_plan[0].operators) == len(expected_ops + expected_view_ops(config)))
363+
self.assertTrue(
364+
len(program.execution_plan[0].operators)
365+
== len(expected_ops + expected_view_ops(config))
366+
)
367367

368368
def test_operators_unique(self) -> None:
369369
class OpRepeatedModule(torch.nn.Module):

exir/tests/test_remove_view_copy.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def test_spec(self) -> None:
205205
self.assertEqual(
206206
instructions[4].instr_args.op_index, 2
207207
) # aten:view_copy @ idx11
208-
208+
209209
def test_elide_static_views_does_not_remove_dynamic_views(self) -> None:
210210
class TestModel(nn.Module):
211211
def __init__(self):
@@ -215,12 +215,14 @@ def forward(self, x):
215215
x = x + x
216216
x = x.view(-1, 1)
217217
return 2 * x
218-
218+
219219
model = TestModel()
220220
model.eval()
221221
example_inputs = (torch.rand(5, 6),)
222222
dynamic_shapes = {"x": {0: torch.export.Dim("dim0", min=1, max=10)}}
223-
ep = torch.export.export(model, example_inputs, strict=True, dynamic_shapes=dynamic_shapes)
223+
ep = torch.export.export(
224+
model, example_inputs, strict=True, dynamic_shapes=dynamic_shapes
225+
)
224226
etpm = to_edge(ep).to_executorch(
225227
config=ExecutorchBackendConfig(
226228
remove_view_copy=True,
@@ -230,5 +232,3 @@ def forward(self, x):
230232
plan = etpm.executorch_program.execution_plan[0]
231233
op_names = [op.name for op in plan.operators]
232234
self.assertTrue("executorch_prim::et_view" in op_names)
233-
234-

0 commit comments

Comments
 (0)