Skip to content

Commit 8d6d18a

Browse files
tarun292facebook-github-bot
authored andcommitted
Exclude log_outputs() from execute profiling scope (#6325)
Summary: Pull Request resolved: #6325 `log_outputs()` should not be included in the `execute()` profiling scope as it distorts the profiling numbers especially on smaller embedded platforms like Xtensa. Reviewed By: mcremon-meta Differential Revision: D64541740 fbshipit-source-id: 82e3a3be82cb8a4ed6f37fa9eddbf0240876d675
1 parent 6669e18 commit 8d6d18a

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

runtime/executor/method.cpp

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1191,8 +1191,9 @@ Error Method::step() {
11911191
static_cast<int32_t>(step_state_.chain_idx),
11921192
static_cast<uint32_t>(step_state_.instr_idx));
11931193
EXECUTORCH_SCOPE_PROF("Method::step");
1194-
internal::EventTracerProfileMethodScope event_tracer_profile_scope =
1195-
internal::EventTracerProfileMethodScope(event_tracer_, "Method::step");
1194+
EventTracerEntry event_tracer_entry =
1195+
internal::event_tracer_begin_profiling_event(
1196+
event_tracer_, "Method::step");
11961197
ET_CHECK_OR_RETURN_ERROR(
11971198
initialized(),
11981199
InvalidState,
@@ -1218,6 +1219,7 @@ Error Method::step() {
12181219
return status;
12191220
}
12201221

1222+
internal::event_tracer_end_profiling_event(event_tracer_, event_tracer_entry);
12211223
// end of the current chain, advance to the next chain
12221224
if (step_state_.instr_idx == num_instructions) {
12231225
step_state_.instr_idx = 0;
@@ -1233,8 +1235,9 @@ Error Method::experimental_step() {
12331235

12341236
Error Method::execute() {
12351237
internal::event_tracer_create_event_block(event_tracer_, "Execute");
1236-
internal::EventTracerProfileMethodScope event_tracer_profile_scope =
1237-
internal::EventTracerProfileMethodScope(event_tracer_, "Method::execute");
1238+
EventTracerEntry event_tracer_entry =
1239+
internal::event_tracer_begin_profiling_event(
1240+
event_tracer_, "Method::execute");
12381241
EXECUTORCH_SCOPE_PROF("Method::execute");
12391242
ET_CHECK_OR_RETURN_ERROR(
12401243
initialized(),
@@ -1270,7 +1273,7 @@ Error Method::execute() {
12701273
}
12711274
}
12721275
}
1273-
1276+
internal::event_tracer_end_profiling_event(event_tracer_, event_tracer_entry);
12741277
log_outputs();
12751278

12761279
// TODO(jakeszwe, dbort): Decide on calling execute back to back without

0 commit comments

Comments
 (0)